From: Stefan Beller <sbeller@google.com>
To: Kevin Willford <kcwillford@gmail.com>
Cc: Jeff King <peff@peff.net>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Ben Peart <peartben@gmail.com>,
Kevin Willford <kewillf@microsoft.com>
Subject: Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one
Date: Thu, 10 Aug 2017 13:33:55 -0700 [thread overview]
Message-ID: <CAGZ79kbM6F8SMB4K1d_fY1TEEOvVJfuvot7tv8=KWqOtLUgB2g@mail.gmail.com> (raw)
In-Reply-To: <e71f1aab-d93a-2774-4378-8431bd33e146@gmail.com>
On Thu, Aug 10, 2017 at 12:57 PM, Kevin Willford <kcwillford@gmail.com> wrote:
> Here are some of the performance numbers from the windows repo.
> I will work on writing a perf test for this change so that we
> have a better idea on smaller repo what the impact of this change
> is on them.
>
> | w/o | with fix |
> -----------------------------------
> git checkout | 36.08 s | 33.34 s |
> -----------------------------------
> git checkout | 32.54 s | 28.26 s |
> -----------------------------------
> git checkout | 44.10 s | 38.13 s |
> -----------------------------------
> git merge | 32.90 s | 30.56 s |
> -----------------------------------
> git rebase | 46.14 s | 42.18 s |
>
~10-15% is impressive for this patch, I certainly did not
expect as much. Thanks for providing the numbers!
Stefan
next prev parent reply other threads:[~2017-08-10 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 18:47 [PATCH] cache-tree: remove use of strbuf_addf in update_one Kevin Willford
2017-08-10 18:58 ` Stefan Beller
2017-08-10 19:03 ` Jeff King
2017-08-10 19:57 ` Kevin Willford
2017-08-10 20:33 ` Stefan Beller [this message]
2017-08-14 18:51 ` Junio C Hamano
2017-08-11 13:08 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kbM6F8SMB4K1d_fY1TEEOvVJfuvot7tv8=KWqOtLUgB2g@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kcwillford@gmail.com \
--cc=kewillf@microsoft.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).