From: Stefan Beller <sbeller@google.com> To: Brandon Williams <bmwill@google.com> Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>, Philip Oakley <philipoakley@iee.org>, Derrick Stolee <stolee@gmail.com>, Jonathan Nieder <jrnieder@gmail.com> Subject: Re: [PATCH 20/26] fetch-pack: perform a fetch using v2 Date: Wed, 3 Jan 2018 17:23:08 -0800 [thread overview] Message-ID: <CAGZ79kbM4Jk=aHJu7+U3AcgFMh0-jbbu4RPLUkKwM0mDWge+gA@mail.gmail.com> (raw) In-Reply-To: <20180103001828.205012-21-bmwill@google.com> On Tue, Jan 2, 2018 at 4:18 PM, Brandon Williams <bmwill@google.com> wrote: > When communicating with a v2 server, perform a fetch by requesting the > 'fetch' command. > > Signed-off-by: Brandon Williams <bmwill@google.com> > --- > builtin/fetch-pack.c | 2 +- > fetch-pack.c | 267 ++++++++++++++++++++++++++++++++++++++++++++++++- > fetch-pack.h | 4 +- > t/t5701-protocol-v2.sh | 40 ++++++++ > transport.c | 8 +- > 5 files changed, 314 insertions(+), 7 deletions(-) > > diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c > index f492e8abd..867dd3cc7 100644 > --- a/builtin/fetch-pack.c > +++ b/builtin/fetch-pack.c > @@ -213,7 +213,7 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) > } > > ref = fetch_pack(&args, fd, conn, ref, dest, sought, nr_sought, > - &shallow, pack_lockfile_ptr); > + &shallow, pack_lockfile_ptr, protocol_v0); > if (pack_lockfile) { > printf("lock %s\n", pack_lockfile); > fflush(stdout); > diff --git a/fetch-pack.c b/fetch-pack.c > index 9f6b07ad9..c26fdc539 100644 > --- a/fetch-pack.c > +++ b/fetch-pack.c > @@ -1008,6 +1008,262 @@ static struct ref *do_fetch_pack(struct fetch_pack_args *args, > return ref; > } > > +static void add_wants(const struct ref *wants, struct strbuf *req_buf) > +{ > + for ( ; wants ; wants = wants->next) { > + const struct object_id *remote = &wants->old_oid; > + const char *remote_hex; > + struct object *o; > + > + /* > + * If that object is complete (i.e. it is an ancestor of a > + * local ref), we tell them we have it but do not have to > + * tell them about its ancestors, which they already know > + * about. > + * > + * We use lookup_object here because we are only > + * interested in the case we *know* the object is > + * reachable and we have already scanned it. > + */ > + if (((o = lookup_object(remote->hash)) != NULL) && > + (o->flags & COMPLETE)) { > + continue; > + } > + > + remote_hex = oid_to_hex(remote); > + packet_buf_write(req_buf, "want %s\n", remote_hex); > + } > +} > + > +static int add_haves(struct strbuf *req_buf, int *in_vain) > +{ > + int ret = 0; > + int haves_added = 0; > + const struct object_id *oid; > + > + while ((oid = get_rev())) { > + packet_buf_write(req_buf, "have %s\n", oid_to_hex(oid)); > + if (++haves_added >= INITIAL_FLUSH) > + break; > + }; > + > + *in_vain += haves_added; > + if (!haves_added || *in_vain >= MAX_IN_VAIN) { > + /* Send Done */ > + packet_buf_write(req_buf, "done\n"); > + ret = 1; > + } > + > + return ret; > +} > + > +static int send_haves(int fd_out, int *in_vain) > +{ > + int ret = 0; > + struct strbuf req_buf = STRBUF_INIT; > + > + ret = add_haves(&req_buf, in_vain); > + > + /* Send request */ > + packet_buf_flush(&req_buf); > + write_or_die(fd_out, req_buf.buf, req_buf.len); > + > + strbuf_release(&req_buf); > + return ret; > +} > + > +static int send_fetch_request(int fd_out, const struct fetch_pack_args *args, > + const struct ref *wants, struct oidset *common, > + int *in_vain) > +{ > + int ret = 0; > + struct strbuf req_buf = STRBUF_INIT; > + > + packet_buf_write(&req_buf, "command=fetch"); > + packet_buf_write(&req_buf, "agent=%s", git_user_agent_sanitized()); > + if (args->stateless_rpc) > + packet_buf_write(&req_buf, "stateless-rpc=true"); > + > + packet_buf_delim(&req_buf); > + if (args->use_thin_pack) > + packet_buf_write(&req_buf, "thin-pack"); > + if (args->no_progress) > + packet_buf_write(&req_buf, "no-progress"); > + if (args->include_tag) > + packet_buf_write(&req_buf, "include-tag"); > + if (prefer_ofs_delta) > + packet_buf_write(&req_buf, "ofs-delta"); > + > + /* add wants */ > + add_wants(wants, &req_buf); > + > + /* > + * If we are running stateless-rpc we need to add all the common > + * commits we've found in previous rounds > + */ > + if (args->stateless_rpc) { > + struct oidset_iter iter; > + const struct object_id *oid; > + oidset_iter_init(common, &iter); > + > + while ((oid = oidset_iter_next(&iter))) { > + packet_buf_write(&req_buf, "have %s\n", oid_to_hex(oid)); > + } > + } > + > + /* Add initial haves */ > + ret = add_haves(&req_buf, in_vain); > + > + /* Send request */ > + packet_buf_flush(&req_buf); > + write_or_die(fd_out, req_buf.buf, req_buf.len); > + > + strbuf_release(&req_buf); > + return ret; > +} > + > +static enum ack_type process_ack(const char *line, struct object_id *oid) > +{ > + const char *arg; > + > + if (!strcmp(line, "NAK")) > + return NAK; > + if (skip_prefix(line, "ACK ", &arg)) { > + if (!parse_oid_hex(arg, oid, &arg)) { > + if (strstr(arg, "continue")) > + return ACK_continue; > + if (strstr(arg, "common")) > + return ACK_common; > + if (strstr(arg, "ready")) > + return ACK_ready; > + return ACK; > + } > + } > + if (skip_prefix(line, "ERR ", &arg)) > + die(_("remote error: %s"), arg); > + die(_("git fetch-pack: expected ACK/NAK, got '%s'"), line); > +} > + > +static int process_acks(struct packet_reader *reader, struct oidset *common) > +{ > + int got_ready = 0; > + int got_common = 0; > + while (packet_reader_read(reader) == PACKET_READ_NORMAL) { > + struct object_id oid; > + struct commit *commit; > + enum ack_type ack = process_ack(reader->line, &oid); > + > + switch (ack) { > + case ACK_ready: > + clear_prio_queue(&rev_list); > + got_ready = 1; > + /* fallthrough */ > + case ACK_common: > + oidset_insert(common, &oid); > + commit = lookup_commit(&oid); > + mark_common(commit, 0, 1); > + got_common = 1; > + break; > + case NAK: > + break; > + case ACK: > + case ACK_continue: > + die("ACK/ACK_continue not supported"); > + } > + } > + > + if (reader->status != PACKET_READ_FLUSH && > + reader->status != PACKET_READ_DELIM) > + die("Error during processing acks: %d", reader->status); > + > + /* return 0 if no common, 1 if there are common, or 2 if ready */ > + return got_ready + got_common; > +} > + > +#define FETCH_CHECK_LOCAL 0 > +#define FETCH_SEND_REQUEST 1 > +#define FETCH_PROCESS_ACKS 2 > +#define FETCH_SEND_HAVES 3 > +#define FETCH_GET_PACK 4 > +#define FETCH_DONE 5 > + > +static struct ref *do_fetch_pack_v2(struct fetch_pack_args *args, > + int fd[2], > + const struct ref *orig_ref, > + struct ref **sought, int nr_sought, > + char **pack_lockfile) > +{ > + struct ref *ref = copy_ref_list(orig_ref); > + int state = FETCH_CHECK_LOCAL; Is there any reason to use #defines over an enum here? > + struct oidset common = OIDSET_INIT; > + struct packet_reader reader; > + int in_vain = 0; > + packet_reader_init(&reader, fd[0], NULL, 0, > + PACKET_READ_CHOMP_NEWLINE); > + > + while (state != FETCH_DONE) { > + switch (state) { > + case FETCH_CHECK_LOCAL: > + sort_ref_list(&ref, ref_compare_name); > + QSORT(sought, nr_sought, cmp_ref_by_name); > + > + /* v2 supports these by default */ > + allow_unadvertised_object_request |= ALLOW_REACHABLE_SHA1; > + use_sideband = 2; > + > + /* Filter 'ref' by 'sought' and those that aren't local */ > + if (everything_local(args, &ref, sought, nr_sought)) > + state = FETCH_DONE; > + else > + state = FETCH_SEND_REQUEST; > + break; > + case FETCH_SEND_REQUEST: > + if (send_fetch_request(fd[1], args, ref, &common, &in_vain)) > + state = FETCH_GET_PACK; > + else > + state = FETCH_PROCESS_ACKS; > + break; > + case FETCH_PROCESS_ACKS: > + /* Process ACKs/NAKs */ > + switch (process_acks(&reader, &common)) { > + case 2: > + state = FETCH_GET_PACK; > + break; > + case 1: > + in_vain = 0; > + /* fallthrough */ > + default: > + if (args->stateless_rpc) > + state = FETCH_SEND_REQUEST; > + else > + state = FETCH_SEND_HAVES; > + break; > + } > + break; > + case FETCH_SEND_HAVES: > + if (send_haves(fd[1], &in_vain)) > + state = FETCH_GET_PACK; > + else > + state = FETCH_PROCESS_ACKS; > + break; > + case FETCH_GET_PACK: > + /* get the pack */ > + if (get_pack(args, fd, pack_lockfile)) > + die(_("git fetch-pack: fetch failed.")); > + > + state = FETCH_DONE; > + break; > + case FETCH_DONE: > + break; > + default: > + die("invalid state"); > + } > + } > + > + oidset_clear(&common); > + return ref; > +} > + > static void fetch_pack_config(void) > { > git_config_get_int("fetch.unpacklimit", &fetch_unpack_limit); > @@ -1153,7 +1409,8 @@ struct ref *fetch_pack(struct fetch_pack_args *args, > const char *dest, > struct ref **sought, int nr_sought, > struct oid_array *shallow, > - char **pack_lockfile) > + char **pack_lockfile, > + enum protocol_version version) > { > struct ref *ref_cpy; > struct shallow_info si; > @@ -1167,8 +1424,12 @@ struct ref *fetch_pack(struct fetch_pack_args *args, > die(_("no matching remote head")); > } > prepare_shallow_info(&si, shallow); > - ref_cpy = do_fetch_pack(args, fd, ref, sought, nr_sought, > - &si, pack_lockfile); > + if (version == protocol_v2) > + ref_cpy = do_fetch_pack_v2(args, fd, ref, sought, nr_sought, > + pack_lockfile); > + else > + ref_cpy = do_fetch_pack(args, fd, ref, sought, nr_sought, > + &si, pack_lockfile); > reprepare_packed_git(); > update_shallow(args, sought, nr_sought, &si); > clear_shallow_info(&si); > diff --git a/fetch-pack.h b/fetch-pack.h > index b6aeb43a8..7afca7305 100644 > --- a/fetch-pack.h > +++ b/fetch-pack.h > @@ -3,6 +3,7 @@ > > #include "string-list.h" > #include "run-command.h" > +#include "protocol.h" > > struct oid_array; > > @@ -43,7 +44,8 @@ struct ref *fetch_pack(struct fetch_pack_args *args, > struct ref **sought, > int nr_sought, > struct oid_array *shallow, > - char **pack_lockfile); > + char **pack_lockfile, > + enum protocol_version version); > > /* > * Print an appropriate error message for each sought ref that wasn't > diff --git a/t/t5701-protocol-v2.sh b/t/t5701-protocol-v2.sh > index 7d8aeb766..3e411e178 100755 > --- a/t/t5701-protocol-v2.sh > +++ b/t/t5701-protocol-v2.sh > @@ -33,4 +33,44 @@ test_expect_success 'ref advertisment is filtered with ls-remote using protocol > ! grep "refs/tags/" log > ' > > +test_expect_success 'clone with file:// using protocol v2' ' > + GIT_TRACE_PACKET=1 git -c protocol.version=2 \ > + clone "file://$(pwd)/file_parent" file_child 2>log && > + > + git -C file_child log -1 --format=%s >actual && > + git -C file_parent log -1 --format=%s >expect && > + test_cmp expect actual && > + > + # Server responded using protocol v1 > + grep "clone< version 2" log > +' > + > +test_expect_success 'fetch with file:// using protocol v2' ' > + test_commit -C file_parent two && > + > + GIT_TRACE_PACKET=1 git -C file_child -c protocol.version=2 \ > + fetch origin 2>log && > + > + git -C file_child log -1 --format=%s origin/master >actual && > + git -C file_parent log -1 --format=%s >expect && > + test_cmp expect actual && > + > + # Server responded using protocol v1 > + grep "fetch< version 2" log > +' > + > +test_expect_success 'ref advertisment is filtered during fetch using protocol v2' ' > + test_commit -C file_parent three && > + > + GIT_TRACE_PACKET=1 git -C file_child -c protocol.version=2 \ > + fetch origin master 2>log && > + > + git -C file_child log -1 --format=%s origin/master >actual && > + git -C file_parent log -1 --format=%s >expect && > + test_cmp expect actual && > + > + grep "ref-pattern master" log && > + ! grep "refs/tags/" log > +' > + > test_done > diff --git a/transport.c b/transport.c > index 6ea3905e3..4fdbd9adc 100644 > --- a/transport.c > +++ b/transport.c > @@ -256,14 +256,18 @@ static int fetch_refs_via_pack(struct transport *transport, > > switch (data->version) { > case protocol_v2: > - die("support for protocol v2 not implemented yet"); > + refs = fetch_pack(&args, data->fd, data->conn, > + refs_tmp ? refs_tmp : transport->remote_refs, > + dest, to_fetch, nr_heads, &data->shallow, > + &transport->pack_lockfile, data->version); > + packet_flush(data->fd[1]); > break; > case protocol_v1: > case protocol_v0: > refs = fetch_pack(&args, data->fd, data->conn, > refs_tmp ? refs_tmp : transport->remote_refs, > dest, to_fetch, nr_heads, &data->shallow, > - &transport->pack_lockfile); > + &transport->pack_lockfile, data->version); > break; > case protocol_unknown_version: > BUG("unknown protocol version"); > -- > 2.15.1.620.gb9897f4670-goog >
next prev parent reply other threads:[~2018-01-04 1:23 UTC|newest] Thread overview: 362+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-03 0:18 [PATCH 00/26] protocol version 2 Brandon Williams 2018-01-03 0:18 ` [PATCH 01/26] pkt-line: introduce packet_read_with_status Brandon Williams 2018-01-03 19:27 ` Stefan Beller 2018-01-05 23:41 ` Brandon Williams 2018-01-09 18:04 ` Jonathan Tan 2018-01-09 19:28 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 02/26] pkt-line: introduce struct packet_reader Brandon Williams 2018-01-09 18:08 ` Jonathan Tan 2018-01-09 19:19 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 03/26] pkt-line: add delim packet support Brandon Williams 2018-01-03 0:18 ` [PATCH 04/26] upload-pack: convert to a builtin Brandon Williams 2018-01-03 20:33 ` Stefan Beller 2018-01-03 20:39 ` Brandon Williams 2018-02-21 21:47 ` Jonathan Nieder 2018-02-21 23:35 ` Junio C Hamano 2018-01-03 0:18 ` [PATCH 05/26] upload-pack: factor out processing lines Brandon Williams 2018-01-03 20:38 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 06/26] transport: use get_refs_via_connect to get refs Brandon Williams 2018-01-03 21:20 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 07/26] connect: convert get_remote_heads to use struct packet_reader Brandon Williams 2018-01-09 18:27 ` Jonathan Tan 2018-01-09 19:09 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 08/26] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-01-03 0:18 ` [PATCH 09/26] transport: store protocol version Brandon Williams 2018-01-09 18:41 ` Jonathan Tan 2018-01-09 19:15 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 10/26] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-01-03 0:18 ` [PATCH 11/26] serve: introduce git-serve Brandon Williams 2018-01-09 20:24 ` Jonathan Tan 2018-01-09 22:16 ` Brandon Williams 2018-01-09 22:28 ` Jonathan Tan 2018-01-09 22:34 ` Brandon Williams 2018-02-01 18:48 ` Jeff Hostetler 2018-02-01 18:57 ` Stefan Beller 2018-02-01 19:09 ` Jeff Hostetler 2018-02-01 20:05 ` Brandon Williams 2018-02-01 19:45 ` Randall S. Becker 2018-02-01 20:08 ` 'Brandon Williams' 2018-02-01 20:37 ` Randall S. Becker 2018-02-01 20:50 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 12/26] ls-refs: introduce ls-refs server command Brandon Williams 2018-01-04 0:17 ` Stefan Beller 2018-01-05 23:49 ` Brandon Williams 2018-01-09 20:50 ` Jonathan Tan 2018-01-16 19:23 ` Brandon Williams 2018-02-01 19:16 ` Jeff Hostetler 2018-02-07 0:55 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 13/26] connect: request remote refs using v2 Brandon Williams 2018-01-09 22:24 ` Jonathan Tan 2018-01-03 0:18 ` [PATCH 14/26] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-01-03 0:18 ` [PATCH 15/26] transport: convert transport_get_remote_refs " Brandon Williams 2018-01-03 0:18 ` [PATCH 16/26] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-01-03 0:18 ` [PATCH 17/26] fetch: pass ref patterns when fetching Brandon Williams 2018-01-03 0:18 ` [PATCH 18/26] push: pass ref patterns when pushing Brandon Williams 2018-01-03 0:18 ` [PATCH 19/26] upload-pack: introduce fetch server command Brandon Williams 2018-01-04 1:07 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 20/26] fetch-pack: perform a fetch using v2 Brandon Williams 2018-01-04 1:23 ` Stefan Beller [this message] 2018-01-05 23:55 ` Brandon Williams 2018-01-10 0:05 ` Jonathan Tan 2018-01-03 0:18 ` [PATCH 21/26] transport-helper: remove name parameter Brandon Williams 2018-01-03 0:18 ` [PATCH 22/26] transport-helper: refactor process_connect_service Brandon Williams 2018-01-03 0:18 ` [PATCH 23/26] transport-helper: introduce connect-half-duplex Brandon Williams 2018-01-03 0:18 ` [PATCH 24/26] pkt-line: add packet_buf_write_len function Brandon Williams 2018-01-03 0:18 ` [PATCH 25/26] remote-curl: create copy of the service name Brandon Williams 2018-01-03 0:18 ` [PATCH 26/26] remote-curl: implement connect-half-duplex command Brandon Williams 2018-01-10 0:10 ` Jonathan Tan 2018-01-10 17:57 ` Jonathan Tan 2018-01-11 1:09 ` Brandon Williams 2018-01-09 17:55 ` [PATCH 00/26] protocol version 2 Jonathan Tan 2018-01-11 0:23 ` Brandon Williams 2018-01-25 23:58 ` [PATCH v2 00/27] " Brandon Williams 2018-01-25 23:58 ` [PATCH v2 01/27] pkt-line: introduce packet_read_with_status Brandon Williams 2018-01-25 23:58 ` [PATCH v2 02/27] pkt-line: introduce struct packet_reader Brandon Williams 2018-01-25 23:58 ` [PATCH v2 03/27] pkt-line: add delim packet support Brandon Williams 2018-01-25 23:58 ` [PATCH v2 04/27] upload-pack: convert to a builtin Brandon Williams 2018-01-25 23:58 ` [PATCH v2 05/27] upload-pack: factor out processing lines Brandon Williams 2018-01-26 20:12 ` Stefan Beller 2018-01-26 21:33 ` Brandon Williams 2018-01-31 14:08 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 06/27] transport: use get_refs_via_connect to get refs Brandon Williams 2018-01-25 23:58 ` [PATCH v2 07/27] connect: convert get_remote_heads to use struct packet_reader Brandon Williams 2018-01-25 23:58 ` [PATCH v2 08/27] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-01-31 14:40 ` Derrick Stolee 2018-02-01 17:57 ` Brandon Williams 2018-01-25 23:58 ` [PATCH v2 09/27] transport: store protocol version Brandon Williams 2018-01-31 14:45 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 10/27] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-01-31 14:54 ` Derrick Stolee 2018-02-02 22:44 ` Brandon Williams 2018-02-05 14:14 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 11/27] test-pkt-line: introduce a packet-line test helper Brandon Williams 2018-01-25 23:58 ` [PATCH v2 12/27] serve: introduce git-serve Brandon Williams 2018-01-26 10:39 ` Duy Nguyen 2018-02-27 5:46 ` Jonathan Nieder 2018-01-31 15:39 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 13/27] ls-refs: introduce ls-refs server command Brandon Williams 2018-01-26 22:20 ` Stefan Beller 2018-02-02 22:31 ` Brandon Williams 2018-01-25 23:58 ` [PATCH v2 14/27] connect: request remote refs using v2 Brandon Williams 2018-01-31 15:22 ` Derrick Stolee 2018-01-31 20:10 ` Eric Sunshine 2018-01-31 22:14 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 15/27] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-01-25 23:58 ` [PATCH v2 16/27] transport: convert transport_get_remote_refs " Brandon Williams 2018-01-25 23:58 ` [PATCH v2 17/27] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-01-25 23:58 ` [PATCH v2 18/27] fetch: pass ref patterns when fetching Brandon Williams 2018-01-25 23:58 ` [PATCH v2 19/27] push: pass ref patterns when pushing Brandon Williams 2018-01-25 23:58 ` [PATCH v2 20/27] upload-pack: introduce fetch server command Brandon Williams 2018-01-25 23:58 ` [PATCH v2 21/27] fetch-pack: perform a fetch using v2 Brandon Williams 2018-01-25 23:58 ` [PATCH v2 22/27] transport-helper: remove name parameter Brandon Williams 2018-01-25 23:58 ` [PATCH v2 23/27] transport-helper: refactor process_connect_service Brandon Williams 2018-01-25 23:58 ` [PATCH v2 24/27] transport-helper: introduce stateless-connect Brandon Williams 2018-01-25 23:58 ` [PATCH v2 25/27] pkt-line: add packet_buf_write_len function Brandon Williams 2018-01-25 23:58 ` [PATCH v2 26/27] remote-curl: create copy of the service name Brandon Williams 2018-01-25 23:58 ` [PATCH v2 27/27] remote-curl: implement stateless-connect command Brandon Williams 2018-01-31 16:00 ` [PATCH v2 00/27] protocol version 2 Derrick Stolee 2018-02-07 0:58 ` Brandon Williams 2018-02-01 19:40 ` Jeff Hostetler 2018-02-07 1:12 ` [PATCH v3 00/35] " Brandon Williams 2018-02-07 1:12 ` [PATCH v3 01/35] pkt-line: introduce packet_read_with_status Brandon Williams 2018-02-13 0:25 ` Jonathan Nieder 2018-02-07 1:12 ` [PATCH v3 02/35] pkt-line: introduce struct packet_reader Brandon Williams 2018-02-13 0:49 ` Jonathan Nieder 2018-02-27 18:14 ` Brandon Williams 2018-02-27 19:20 ` Jonathan Nieder 2018-02-27 5:57 ` Jonathan Nieder 2018-02-27 6:12 ` Jonathan Nieder 2018-02-07 1:12 ` [PATCH v3 03/35] pkt-line: add delim packet support Brandon Williams 2018-02-22 19:13 ` Stefan Beller 2018-02-22 19:37 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 04/35] upload-pack: convert to a builtin Brandon Williams 2018-02-21 21:44 ` Jonathan Tan 2018-02-22 9:58 ` Jeff King 2018-02-22 18:07 ` Brandon Williams 2018-02-22 18:14 ` Jeff King 2018-02-22 19:38 ` Jonathan Nieder 2018-02-22 20:19 ` Jeff King 2018-02-22 20:21 ` Jeff King 2018-02-22 21:26 ` Jonathan Nieder 2018-02-22 21:44 ` Jeff King 2018-03-12 22:43 ` Jonathan Nieder 2018-03-12 23:28 ` Jeff King 2018-03-12 23:37 ` Jonathan Nieder 2018-03-12 23:52 ` Jeff King 2018-02-23 21:09 ` Brandon Williams 2018-03-03 4:24 ` Jeff King 2018-02-22 21:24 ` Jonathan Nieder 2018-02-22 21:44 ` Jeff King 2018-02-22 22:21 ` Jeff King 2018-02-22 22:42 ` Jonathan Nieder 2018-02-22 23:05 ` Jeff King 2018-02-22 23:23 ` Jeff King 2018-02-07 1:12 ` [PATCH v3 05/35] upload-pack: factor out processing lines Brandon Williams 2018-02-22 19:31 ` Stefan Beller 2018-02-22 19:39 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 06/35] transport: use get_refs_via_connect to get refs Brandon Williams 2018-02-27 6:08 ` Jonathan Nieder 2018-02-27 18:17 ` Brandon Williams 2018-02-27 19:25 ` Jonathan Nieder 2018-02-27 19:46 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 07/35] connect: convert get_remote_heads to use struct packet_reader Brandon Williams 2018-02-22 19:52 ` Stefan Beller 2018-02-22 20:09 ` Stefan Beller 2018-02-23 21:30 ` Brandon Williams 2018-02-23 21:48 ` Stefan Beller 2018-02-23 22:56 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 08/35] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-02-21 22:11 ` Jonathan Tan 2018-02-22 18:17 ` Brandon Williams 2018-02-22 19:22 ` Jonathan Tan 2018-02-07 1:12 ` [PATCH v3 09/35] transport: store protocol version Brandon Williams 2018-02-07 1:12 ` [PATCH v3 10/35] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-02-27 6:18 ` Jonathan Nieder 2018-02-27 18:41 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper Brandon Williams 2018-02-22 20:40 ` Stefan Beller 2018-02-23 21:22 ` Brandon Williams 2018-03-03 4:25 ` Jeff King 2018-03-05 18:48 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 12/35] serve: introduce git-serve Brandon Williams 2018-02-21 22:45 ` Jonathan Tan 2018-02-23 21:33 ` Brandon Williams 2018-02-27 18:05 ` Jonathan Tan 2018-02-27 18:34 ` Brandon Williams 2018-02-22 9:33 ` Jeff King 2018-02-23 21:45 ` Brandon Williams 2018-03-03 4:33 ` Jeff King 2018-03-05 18:43 ` Brandon Williams 2018-03-05 20:52 ` Jeff King 2018-03-05 21:36 ` Jonathan Nieder 2018-03-06 6:29 ` Jeff King 2018-03-12 23:46 ` Jeff King 2018-02-07 1:12 ` [PATCH v3 13/35] ls-refs: introduce ls-refs server command Brandon Williams 2018-02-22 9:48 ` Jeff King 2018-02-23 0:45 ` Brandon Williams 2018-02-24 0:19 ` Brandon Williams 2018-02-24 4:03 ` Jeff King 2018-02-24 4:01 ` Jeff King 2018-02-26 22:33 ` Junio C Hamano 2018-02-27 0:02 ` Ævar Arnfjörð Bjarmason 2018-02-27 5:15 ` Jonathan Nieder 2018-02-27 18:02 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 14/35] connect: request remote refs using v2 Brandon Williams 2018-02-21 22:54 ` Jonathan Tan 2018-02-22 18:19 ` Brandon Williams 2018-02-22 18:26 ` Jeff King 2018-02-22 19:25 ` Jonathan Tan 2018-02-27 6:21 ` Jonathan Nieder 2018-02-27 21:58 ` Junio C Hamano 2018-02-27 22:04 ` Jeff King 2018-02-27 22:10 ` Eric Sunshine 2018-02-27 22:18 ` Jeff King 2018-02-27 23:32 ` Junio C Hamano 2018-02-27 6:51 ` Jonathan Nieder 2018-02-27 19:30 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-02-21 22:56 ` Jonathan Tan 2018-02-22 18:25 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 16/35] transport: convert transport_get_remote_refs " Brandon Williams 2018-02-21 22:58 ` Jonathan Tan 2018-02-22 18:26 ` Brandon Williams 2018-02-22 19:32 ` Jonathan Tan 2018-02-22 19:51 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 17/35] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-02-07 1:12 ` [PATCH v3 18/35] fetch: pass ref patterns when fetching Brandon Williams 2018-02-27 6:53 ` Jonathan Nieder 2018-02-07 1:12 ` [PATCH v3 19/35] push: pass ref patterns when pushing Brandon Williams 2018-02-27 18:23 ` Stefan Beller 2018-02-07 1:12 ` [PATCH v3 20/35] upload-pack: introduce fetch server command Brandon Williams 2018-02-21 23:46 ` Jonathan Tan 2018-02-22 18:48 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 21/35] fetch-pack: perform a fetch using v2 Brandon Williams 2018-02-24 0:54 ` Jonathan Tan 2018-02-26 22:23 ` Brandon Williams 2018-02-27 19:27 ` Stefan Beller 2018-02-27 19:40 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 22/35] upload-pack: support shallow requests Brandon Williams 2018-02-07 19:00 ` Stefan Beller 2018-02-10 10:23 ` Duy Nguyen 2018-02-13 17:06 ` Brandon Williams 2018-02-27 18:29 ` Jonathan Nieder 2018-02-27 18:57 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 23/35] fetch-pack: " Brandon Williams 2018-02-23 19:37 ` Jonathan Tan 2018-02-23 19:56 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 24/35] connect: refactor git_connect to only get the protocol version once Brandon Williams 2018-02-21 23:51 ` Jonathan Tan 2018-02-07 1:13 ` [PATCH v3 25/35] connect: don't request v2 when pushing Brandon Williams 2018-02-07 1:13 ` [PATCH v3 26/35] transport-helper: remove name parameter Brandon Williams 2018-02-27 23:03 ` Jonathan Nieder 2018-02-07 1:13 ` [PATCH v3 27/35] transport-helper: refactor process_connect_service Brandon Williams 2018-02-07 1:13 ` [PATCH v3 28/35] transport-helper: introduce stateless-connect Brandon Williams 2018-02-22 0:01 ` Jonathan Tan 2018-02-22 18:53 ` Brandon Williams 2018-02-22 21:55 ` Jonathan Tan 2018-02-27 23:30 ` Jonathan Nieder 2018-02-28 19:09 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 29/35] pkt-line: add packet_buf_write_len function Brandon Williams 2018-02-27 23:11 ` Jonathan Nieder 2018-02-28 1:08 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 30/35] remote-curl: create copy of the service name Brandon Williams 2018-02-22 0:06 ` Jonathan Tan 2018-02-22 18:56 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 31/35] remote-curl: store the protocol version the server responded with Brandon Williams 2018-02-27 23:17 ` Jonathan Nieder 2018-02-07 1:13 ` [PATCH v3 32/35] http: allow providing extra headers for http requests Brandon Williams 2018-02-22 0:09 ` Jonathan Tan 2018-02-22 18:58 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 33/35] http: don't always add Git-Protocol header Brandon Williams 2018-02-07 1:13 ` [PATCH v3 34/35] remote-curl: implement stateless-connect command Brandon Williams 2018-02-28 0:05 ` Jonathan Nieder 2018-02-28 20:21 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 35/35] remote-curl: don't request v2 when pushing Brandon Williams 2018-02-22 0:12 ` Jonathan Tan 2018-02-22 18:59 ` Brandon Williams 2018-02-22 19:09 ` Brandon Williams 2018-02-12 14:50 ` [PATCH v3 00/35] protocol version 2 Derrick Stolee 2018-02-21 20:01 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 " Brandon Williams 2018-02-28 23:22 ` [PATCH v4 01/35] pkt-line: introduce packet_read_with_status Brandon Williams 2018-03-13 19:35 ` Jonathan Tan 2018-03-13 19:52 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 02/35] pkt-line: allow peeking a packet line without consuming it Brandon Williams 2018-03-01 20:48 ` Junio C Hamano 2018-03-12 21:56 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 03/35] pkt-line: add delim packet support Brandon Williams 2018-03-01 20:50 ` Junio C Hamano 2018-03-01 21:04 ` Junio C Hamano 2018-03-01 22:49 ` Brandon Williams 2018-03-01 23:43 ` Junio C Hamano 2018-02-28 23:22 ` [PATCH v4 04/35] upload-pack: convert to a builtin Brandon Williams 2018-03-13 16:40 ` Jonathan Tan 2018-03-13 19:50 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 05/35] upload-pack: factor out processing lines Brandon Williams 2018-03-01 21:25 ` Junio C Hamano 2018-03-12 22:24 ` Brandon Williams 2018-03-12 22:39 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 06/35] transport: use get_refs_via_connect to get refs Brandon Williams 2018-03-01 21:25 ` Junio C Hamano 2018-02-28 23:22 ` [PATCH v4 07/35] connect: convert get_remote_heads to use struct packet_reader Brandon Williams 2018-02-28 23:22 ` [PATCH v4 08/35] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-03-13 15:49 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 09/35] transport: store protocol version Brandon Williams 2018-02-28 23:22 ` [PATCH v4 10/35] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 11/35] test-pkt-line: introduce a packet-line test helper Brandon Williams 2018-02-28 23:22 ` [PATCH v4 12/35] serve: introduce git-serve Brandon Williams 2018-03-01 23:11 ` Junio C Hamano 2018-03-12 22:08 ` Brandon Williams 2018-03-02 20:42 ` Junio C Hamano 2018-03-13 21:40 ` Brandon Williams 2018-03-02 20:56 ` Junio C Hamano 2018-03-13 21:35 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 13/35] ls-refs: introduce ls-refs server command Brandon Williams 2018-03-02 21:13 ` Junio C Hamano 2018-03-13 21:27 ` Brandon Williams 2018-03-03 4:43 ` Jeff King 2018-03-05 18:21 ` Brandon Williams 2018-03-05 18:29 ` Jonathan Nieder 2018-03-05 20:38 ` Jeff King 2018-03-05 20:28 ` Jeff King 2018-03-13 21:23 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 14/35] connect: request remote refs using v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 15/35] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-02-28 23:22 ` [PATCH v4 16/35] transport: convert transport_get_remote_refs " Brandon Williams 2018-03-13 16:00 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 17/35] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-03-02 22:13 ` Junio C Hamano 2018-02-28 23:22 ` [PATCH v4 18/35] fetch: pass ref patterns when fetching Brandon Williams 2018-03-02 22:20 ` Junio C Hamano 2018-03-12 22:18 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 19/35] push: pass ref patterns when pushing Brandon Williams 2018-03-02 22:25 ` Junio C Hamano 2018-03-12 22:20 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 20/35] upload-pack: introduce fetch server command Brandon Williams 2018-03-13 16:20 ` Jonathan Tan 2018-03-13 21:49 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 21/35] fetch-pack: perform a fetch using v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 22/35] fetch-pack: support shallow requests Brandon Williams 2018-02-28 23:22 ` [PATCH v4 23/35] connect: refactor git_connect to only get the protocol version once Brandon Williams 2018-02-28 23:22 ` [PATCH v4 24/35] connect: don't request v2 when pushing Brandon Williams 2018-02-28 23:22 ` [PATCH v4 25/35] transport-helper: remove name parameter Brandon Williams 2018-02-28 23:22 ` [PATCH v4 26/35] transport-helper: refactor process_connect_service Brandon Williams 2018-02-28 23:22 ` [PATCH v4 27/35] transport-helper: introduce stateless-connect Brandon Williams 2018-03-13 16:30 ` Jonathan Tan 2018-03-14 17:36 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 28/35] pkt-line: add packet_buf_write_len function Brandon Williams 2018-02-28 23:22 ` [PATCH v4 29/35] remote-curl: create copy of the service name Brandon Williams 2018-03-13 16:32 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 30/35] remote-curl: store the protocol version the server responded with Brandon Williams 2018-02-28 23:22 ` [PATCH v4 31/35] http: allow providing extra headers for http requests Brandon Williams 2018-03-13 16:33 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 32/35] http: don't always add Git-Protocol header Brandon Williams 2018-02-28 23:22 ` [PATCH v4 33/35] http: eliminate "# service" line when using protocol v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 34/35] remote-curl: implement stateless-connect command Brandon Williams 2018-03-02 20:07 ` Johannes Schindelin 2018-03-05 19:35 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 35/35] remote-curl: don't request v2 when pushing Brandon Williams 2018-03-13 16:35 ` Jonathan Tan 2018-03-01 18:41 ` [PATCH v4 00/35] protocol version 2 Junio C Hamano 2018-03-01 19:16 ` Brandon Williams 2018-03-01 20:59 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGZ79kbM4Jk=aHJu7+U3AcgFMh0-jbbu4RPLUkKwM0mDWge+gA@mail.gmail.com' \ --to=sbeller@google.com \ --cc=bmwill@google.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=jrnieder@gmail.com \ --cc=peff@peff.net \ --cc=philipoakley@iee.org \ --cc=stolee@gmail.com \ --subject='Re: [PATCH 20/26] fetch-pack: perform a fetch using v2' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).