From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EE4A71FD99 for ; Fri, 26 Aug 2016 19:16:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752274AbcHZTQ0 (ORCPT ); Fri, 26 Aug 2016 15:16:26 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:38465 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbcHZTQZ (ORCPT ); Fri, 26 Aug 2016 15:16:25 -0400 Received: by mail-it0-f53.google.com with SMTP id g62so7546654ith.1 for ; Fri, 26 Aug 2016 12:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KHizwIylZuxfmdwSJ+Fwx1FaW6rFkQfWe9DCYsizcFU=; b=SC4Jc2hIpneHplcX7hdiMejZt8p2ahZ4qLHTLTzG9h2Rs1jg9nLO1nV7zpJOM/3VID Kc3WtB9cn6iKApA4TVVwp6OYIqrdVWL7oW7dlLpaneXzvtSdHWcvi/J0YARrpaGXVP88 S/Dm2VfM2oraZDWQGhspBRwyOSo+hOG7kNClr3y4ElzvH5CYWn3vT6NDsAUF4aOGnttW l0cC209GV+e9GYjFoVgKFfY88wYCS39CD7NVOdUOzSEXQJD1/k3jDYp5yfKkF7ibSScl UwDgM7zytfmdGvjTh+a7MP2fiRuRQjuYDroAygJGVysNj7q1ETCBfG3v9odu8YmOqb1Z Kqfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KHizwIylZuxfmdwSJ+Fwx1FaW6rFkQfWe9DCYsizcFU=; b=BJR2RIE4GELNI1EM2E7OFJTCj9lyEb6I2Mxuo78lmUgqAjK/eS9Oh6ye9T+E8OIJzM MR+j2KvK1OQ4Kzmr9ukJAaLPvMkUcsWNnx5AGtCp4tPNIVTEXPsZvy3YTvMRRex0/AAA GmWQSm7PfdAUbfuTwW3G1PkCFdpsxRRLdsFZod9gffsAebxhcOOppxa6qucEZ59l6BPu fjtFCYT4fPro+IQO0AAqaIzKKrB4Tznqt5vjUXIdZxd7rH68vIkyriPIEJLdl75Z6/t8 0DJ8egO7zN+Fw7TBcnGdqek7tGAlOLhshJB6KR5T70E726c5c/3UC3z5W3M8XbiOk7Hj Fp/w== X-Gm-Message-State: AE9vXwMKVW/0R+PUwjD+mIrApOZDd/NsiBXrMjUeSYLz8RZAFHnEMb1NjKeqOrRflSZcZCLZAOkEujl6yAxX2EtI X-Received: by 10.107.144.10 with SMTP id s10mr5754628iod.165.1472238984125; Fri, 26 Aug 2016 12:16:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.128.66 with HTTP; Fri, 26 Aug 2016 12:16:23 -0700 (PDT) In-Reply-To: References: <1472230741-5161-1-git-send-email-dev+git@drbeat.li> From: Stefan Beller Date: Fri, 26 Aug 2016 12:16:23 -0700 Message-ID: Subject: Re: [PATCH 1/2] gitk: align the commit summary format to the documentation To: Junio C Hamano Cc: Beat Bolli , Heiko Voigt , "git@vger.kernel.org" , Paul Mackerras Content-Type: text/plain; charset=UTF-8 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 26, 2016 at 11:24 AM, Junio C Hamano wrote: > Beat Bolli writes: > >> In 175d38c (SubmittingPatches: document how to reference previous commits, >> 2016-07-28) the format for referring to older commits was specified. >> >> Make the text generated by the "Copy commit summary" command match this >> format. > > Hmph. I didn't know gitk already had its own command to produce a > short string. I actually think what it produces It was added in d835dbb91fe (gitk: Add a "Copy commit summary" command, 2015-07-18), it doesn't seem to be in your tree yet, so maybe wait with this patch until you pulled gitk? > >> In 175d38c ("SubmittingPatches: document how to reference previous commits", >> 2016-07-28) the format for referring to older commits was specified. > > is easier to read when pasted into a sentence than what the recent > update 175d38ca ("SubmittingPatches: document how to reference > previous commits", 2016-07-28) suggests to do, i.e. > >> In 175d38c (SubmittingPatches: document how to reference previous commits, >> 2016-07-28) the format for referring to older commits was specified. > > Heiko, Stefan, I think you two were involved in adding that new > paragraph. What do you think? So the subtle difference is adding '"' around the commit message subject? I agree we should fix that.