From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Brandon Williams <bmwill@google.com>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCHv2 2/3] submodule-config: rename commit_sha1 to commit_or_tree
Date: Tue, 22 Nov 2016 12:03:31 -0800 [thread overview]
Message-ID: <CAGZ79kavcVs2utBut=tHaKoWzRJSEwBpEjZR9Eh=BbH8Bh_NiQ@mail.gmail.com> (raw)
In-Reply-To: <xmqq8tscgp75.fsf@gitster.mtv.corp.google.com>
On Mon, Nov 21, 2016 at 7:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Doesn't (the) "above", aka submodule_from_path() want the same
> treatment?
fixed in a resend.
> I do not think the commit-sha1 (or commit-or-tree-object-name) is
> "ITS" object name for the submodule. The name belongs to the
> containing superproject commit (or tree), no?
>
> Given a tree-ish in the superproject and a path, return the
> submodule that is bound at the path in the named tree.
I'll take this.
>
> is what I would write for that one. Thinking about it a bit
> further, "treeish_name" would be a much better name for the variable
ok, so treeish_name it is.
>> +'
>
> Perhaps also test a tag that points at the commit?
will fix in a resend.
next prev parent reply other threads:[~2016-11-22 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 23:27 [PATCHv2 0/3] submodule-config: clarify/cleanup docs and header Stefan Beller
2016-11-21 23:27 ` [PATCHv2 1/3] submodule config: inline config_from_{name, path} Stefan Beller
2016-11-22 3:27 ` Junio C Hamano
2016-11-21 23:27 ` [PATCHv2 2/3] submodule-config: rename commit_sha1 to commit_or_tree Stefan Beller
2016-11-22 0:11 ` Brandon Williams
2016-11-22 0:15 ` Stefan Beller
2016-11-22 0:16 ` Brandon Williams
2016-11-22 1:25 ` Stefan Beller
2016-11-22 3:37 ` Junio C Hamano
2016-11-22 20:03 ` Stefan Beller [this message]
2016-11-21 23:27 ` [PATCHv2 3/3] submodule-config: clarify parsing of null_sha1 element Stefan Beller
2016-11-22 0:09 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kavcVs2utBut=tHaKoWzRJSEwBpEjZR9Eh=BbH8Bh_NiQ@mail.gmail.com' \
--to=sbeller@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).