From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Lars Schneider <larsxschneider@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [RFC] Indicate that Git waits for user input via editor
Date: Wed, 15 Nov 2017 16:37:57 -0800 [thread overview]
Message-ID: <CAGZ79kavG+gND_2oqMsB0HgZHbaCx2tRvB++8y7KvLc38mnUiQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqpo8jxdto.fsf@gitster.mtv.corp.google.com>
On Wed, Nov 15, 2017 at 4:33 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>>> I wonder if we can do something like
>>>
>>> git_spawn_editor()
>>> {
>>> const char *EL = "\033[K"; /* Erase in Line */
>>>
>>> /* notice the lack of terminating LF */
>>> fprintf(stderr, "Launching your editor...");
>>
>> "It takes quite some time to launch this special Git Editor"
>>
>> As Lars pointed out, the editor may be launched in the background,
>> that the user would not know, but they might expect a thing to
>> pop up as a modal dialog as is always with UIs.
>>
>> So despite it being technically wrong at this point in time,
>> I would phrase it in past tense or in a way that indicates that the
>> user needs to take action already.
>>
>> The "Launching..." sounds as if I need to wait for an event to occur.
>
> Heh, I wasn't expecting phrasing nitpicks when I was trying to help
> the thread by trying to come up with a way to avoid vertical space
> wastage.
I know you weren't, but maybe it is helpful for the author of the patch
(I presume you may not be the author, after all).
But you are right, I should have started with a more fundamental
answer stating this is a good idea, and I cannot think of a negative
side effect currently.
next prev parent reply other threads:[~2017-11-16 0:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 15:08 [RFC] Indicate that Git waits for user input via editor Lars Schneider
2017-11-15 17:51 ` Stefan Beller
2017-11-15 18:07 ` Lars Schneider
2017-11-15 18:37 ` Stefan Beller
2017-11-15 22:32 ` Junio C Hamano
2017-11-16 0:06 ` Stefan Beller
2017-11-16 0:33 ` Junio C Hamano
2017-11-16 0:37 ` Stefan Beller [this message]
2017-11-16 5:37 ` Junio C Hamano
2017-11-16 6:04 ` [PATCH] launch_editor(): indicate that Git waits for user input Junio C Hamano
2017-11-16 10:25 ` Lars Schneider
2017-11-16 14:58 ` Junio C Hamano
2017-11-16 15:24 ` Lars Schneider
2017-11-17 1:09 ` Junio C Hamano
2017-11-18 17:47 ` Kaartic Sivaraam
2017-11-19 1:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kavG+gND_2oqMsB0HgZHbaCx2tRvB++8y7KvLc38mnUiQ@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).