mailing list mirror (one of many)
 help / Atom feed
From: Stefan Beller <>
To: Prathamesh Chavan <>
Cc: git <>, Christian Couder <>
Subject: Re: [GSoC] Update: Week 3
Date: Mon, 5 Jun 2017 15:25:03 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Jun 5, 2017 at 1:56 PM, Prathamesh Chavan <> wrote:
> 1. foreach: After a discussion over the issue of the path variable in
>    windows, in this week my mentor, Stefan Beller came up with the
>    appropriate solution for the problem after discussing it with Ramsay
>    Jones.

Thanks for having so much faith in my abilities, but it may not be
appropriate, yet. (It does multiple things at once, which is generally
a bad sign already. )

Maybe to be unblocked on the conversion of foreach, you could make
the patch have the original behavior, i.e.

<up_path><submodule path>

which makes sense in the way that it is only converting from shell to C,
not fixing a bug along the way. As we discovered a bug, you could just put
a NEEDSWORK comment explaining what the problem is; deferring solving
the issue until later.

I'll review the other patches.


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-15 17:45 [GSOC Update] Week 2 Pranit Bauva
2016-05-22 19:58 ` [GSoC Update] Week 3 Pranit Bauva
2017-06-05 20:56 [GSoC] Update: " Prathamesh Chavan
2017-06-05 22:25 ` Stefan Beller [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox