From: Stefan Beller <sbeller@google.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] format-patch: clear UNINTERESTING flag before prepare_bases
Date: Tue, 19 Jun 2018 11:18:25 -0700 [thread overview]
Message-ID: <CAGZ79kakUs9A4jSXv6NtsAQtOcaHRPTZOA-X_t_hUHsh50p=+A@mail.gmail.com> (raw)
In-Reply-To: <20180604150543.7304-1-xiaolong.ye@intel.com>
On Mon, Jun 4, 2018 at 8:09 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
> When users specify the commit range with 'Z..C' pattern for format-patch, all
> the parents of Z (including Z) would be marked as UNINTERESTING which would
> prevent revision walk in prepare_bases from getting the prerequisite commits,
> thus `git format-patch --base <base_commit_sha> Z..C` won't be able to generate
> the list of prerequisite patch ids. Clear UNINTERESTING flag with
> clear_object_flags solves this issue.
This makes sense;
Reviewed-by: Stefan Beller <sbeller@google.com>
prev parent reply other threads:[~2018-06-19 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 18:46 format-patch: no 'prerequisite-patch-id' info when specifying commit range Eduardo Habkost
2018-05-30 7:04 ` Ye Xiaolong
2018-06-03 6:07 ` Ye Xiaolong
2018-06-04 2:15 ` Junio C Hamano
2018-06-04 2:41 ` Ye Xiaolong
2018-06-04 15:05 ` [PATCH] format-patch: clear UNINTERESTING flag before prepare_bases Xiaolong Ye
2018-06-04 19:42 ` Eduardo Habkost
2018-06-19 2:40 ` Ye Xiaolong
2018-06-19 18:18 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kakUs9A4jSXv6NtsAQtOcaHRPTZOA-X_t_hUHsh50p=+A@mail.gmail.com' \
--to=sbeller@google.com \
--cc=ehabkost@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).