git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>, cederp@opera.com
Subject: Re: [PATCH] document submodule sync --recursive
Date: Thu, 3 Dec 2015 12:22:04 -0800	[thread overview]
Message-ID: <CAGZ79kaX4ZM++jhPcpU0T8eYDobME=iNtbH3KceWbQOOavpHnA@mail.gmail.com> (raw)
In-Reply-To: <xmqqh9jzthh3.fsf@gitster.mtv.corp.google.com>

On Thu, Dec 3, 2015 at 12:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Tested-by: Per Cederqvist <cederp@opera.com>
>
> Isn't this Reported-by? (genuine question; I haven't caught up with
> my inbox backlog and do not claim having seen everything Per wrote
> to this list).

Per wrote he tested `git submodule sync --recursive` with 2.6.3,
so yeah the tested refers to the underlying command, not this patch.
So Reported-by is better here.

>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>
>>  This applies on origin/master.
>
> Thanks.  Should it go to maintenance track (iow, was the feature
> that wasn't documented already in maint)?

It was introduced via
(82f49f294c,  Teach --recursive to submodule sync, 2012-10-26)
so I guess maint is fine, too

>> @@ -237,6 +237,9 @@ sync::
>>  +
>>  "git submodule sync" synchronizes all submodules while
>>  "git submodule sync \-- A" synchronizes submodule "A" only.
>> ++
>> +If `--recursive` is specified, this command will recurse into the
>> +registered submodules, and update any nested submodules within.

I should have paid more attention here and s/update/sync/.

I'll prepare a resend.

  reply	other threads:[~2015-12-03 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 19:33 [PATCH] document submodule sync --recursive Stefan Beller
2015-12-03 20:17 ` Junio C Hamano
2015-12-03 20:22   ` Stefan Beller [this message]
2015-12-03 20:41     ` [PATCHv2] " Stefan Beller
2015-12-04 21:08       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGZ79kaX4ZM++jhPcpU0T8eYDobME=iNtbH3KceWbQOOavpHnA@mail.gmail.com' \
    --to=sbeller@google.com \
    --cc=cederp@opera.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).