From: Stefan Beller <sbeller@google.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Ivan Tham <pickfire@riseup.net>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Re: GSoC Project | Convert interactive rebase to C
Date: Thu, 23 Mar 2017 11:19:50 -0700 [thread overview]
Message-ID: <CAGZ79kaR6FdoddiZXvSs+xYwGW4cS5r2EuLWNngA5a679puPNw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1703231827060.3767@virtualbox>
On Thu, Mar 23, 2017 at 10:30 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>> Are you sure about that? From what I had looked into userdiff.c, there
>> is no support for shell. There just a recent patch for [go patterns][0].
>> Or perhaps I should have rename it as "userdiff.c: patterns for "shell"
>> language"?
>
> I also could not find any shell patterns in the userdiff code...
Sorry for the confusion on my part. I am unfamiliar with that part of the
diffing lib. I based my assumption on the output of "$ git log -p t/"
which contains hunk headers, that make sense most of the time for shell
code.
>
> Careful. It is a ton of work to get the rebase -i conversion done, and
> then a ton of work to get it integrated. That will fill 3 months, very
> easily.
>
>> > > What do you think of these projects? Would it collide with Valery
>> > > Tolstov's Shell to Builtins proposal?
>
> I missed that proposal, and could only find submodule-related mails on the
> public-inbox server. Care to provide a pointer?
Well I don't think it is a full grown proposal, but a confident attempt to
find a good starting point :)
e.g.
https://public-inbox.org/git/1489145258.10535.0@smtp.yandex.ru/
>> > Curious why all people ask about colliding with Valerys proposal here?
>> > I do not think it would collide, as submodules and rebase are very
>> > different areas of the code base.
>
> Indeed ;-)
Although I had some discussion on what the correct behavior of
"rebase --recurse-submodules" in a superproject should be. But this
sounds like future work after the GSoC is over. ;)
Thanks,
Stefan
next prev parent reply other threads:[~2017-03-23 18:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 16:41 GSoC Project | Convert interactive rebase to C Ivan Tham
2017-03-20 17:41 ` Stefan Beller
2017-03-21 6:05 ` Ivan Tham
2017-03-23 17:30 ` Johannes Schindelin
2017-03-23 18:19 ` Stefan Beller [this message]
2017-03-25 2:17 ` Inaw Tham
2017-03-27 15:11 ` Johannes Schindelin
2017-03-27 16:31 ` Pickfire
2017-03-28 6:27 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kaR6FdoddiZXvSs+xYwGW4cS5r2EuLWNngA5a679puPNw@mail.gmail.com \
--to=sbeller@google.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pickfire@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).