mailing list mirror (one of many)
 help / Atom feed
From: Stefan Beller <>
To: Johannes Schindelin <>
Cc: Ivan Tham <>,
	"" <>
Subject: Re: Re: GSoC Project | Convert interactive rebase to C
Date: Thu, 23 Mar 2017 11:19:50 -0700
Message-ID: <> (raw)
In-Reply-To: <alpine.DEB.2.20.1703231827060.3767@virtualbox>

On Thu, Mar 23, 2017 at 10:30 AM, Johannes Schindelin
<> wrote:
>> Are you sure about that? From what I had looked into userdiff.c, there
>> is no support for shell. There just a recent patch for [go patterns][0].
>> Or perhaps I should have rename it as "userdiff.c: patterns for "shell"
>> language"?
> I also could not find any shell patterns in the userdiff code...

Sorry for the confusion on my part. I am unfamiliar with that part of the
diffing lib. I based my assumption on the output of "$ git log -p t/"
which contains hunk headers, that make sense most of the time for shell

> Careful. It is a ton of work to get the rebase -i conversion done, and
> then a ton of work to get it integrated. That will fill 3 months, very
> easily.
>> > > What do you think of these projects? Would it collide with Valery
>> > > Tolstov's Shell to Builtins proposal?
> I missed that proposal, and could only find submodule-related mails on the
> public-inbox server. Care to provide a pointer?

Well I don't think it is a full grown proposal, but a confident attempt to
find a good starting point :)

>> > Curious why all people ask about colliding with Valerys proposal here?
>> > I do not think it would collide, as submodules and rebase are very
>> > different areas of the code base.
> Indeed ;-)

Although I had some discussion on what the correct behavior of
"rebase --recurse-submodules" in a superproject should be. But this
sounds like future work after the GSoC is over. ;)


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 16:41 Ivan Tham
2017-03-20 17:41 ` Stefan Beller
2017-03-21  6:05   ` Ivan Tham
2017-03-23 17:30     ` Johannes Schindelin
2017-03-23 18:19       ` Stefan Beller [this message]
2017-03-25  2:17       ` Inaw Tham
2017-03-27 15:11         ` Johannes Schindelin
2017-03-27 16:31           ` Pickfire
2017-03-28  6:27             ` Christian Couder

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox