From: Stefan Beller <sbeller@google.com> To: Eric Sunshine <sunshine@sunshineco.com> Cc: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>, Git mailing list <git@vger.kernel.org> Subject: Re: [PATCH 1/8] Doc/gitsubmodules: split a sentence for better readability Date: Mon, 8 Jan 2018 10:33:43 -0800 Message-ID: <CAGZ79kaNujhXPPSHQZuvEAz_NLDT0Opna+W4b84-vnan-1UsOA@mail.gmail.com> (raw) In-Reply-To: <CAPig+cQb1G0H5FS9bMmrqv=T45XoRwp2-2vUAEDayd0hV8PwYA@mail.gmail.com> On Sat, Jan 6, 2018 at 4:29 PM, Eric Sunshine <sunshine@sunshineco.com> wrote: > On Sat, Jan 6, 2018 at 1:46 PM, Kaartic Sivaraam > <kaartic.sivaraam@gmail.com> wrote: >> Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> >> --- >> diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt >> @@ -36,8 +36,8 @@ The `gitlink` entry contains the object name of the commit that the >> The section `submodule.foo.*` in the `.gitmodules` file gives additional >> -hints to Gits porcelain layer such as where to obtain the submodule via >> -the `submodule.foo.url` setting. >> +hints to Gits porcelain layer. For example, the `submodule.foo.url` >> +setting specifies where to obtain the submodule. > > I don't find the original difficult to read (aside, perhaps, from the > missing comma before "such as"), so I don't feel strongly about this > change. Seconded. I am neutral to this change, but as you were keen enough to come up with the patch, I see no reason to reject it. Anyway, let's read on! Thanks, Stefan > > However, since you're touching this, you could apply the s/Gits/Git's/ fix.
next prev parent reply index Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-06 18:46 [PATCH 0/8] Doc/submodules: a few updates Kaartic Sivaraam 2018-01-06 18:46 ` [PATCH 1/8] Doc/gitsubmodules: split a sentence for better readability Kaartic Sivaraam 2018-01-07 0:29 ` Eric Sunshine 2018-01-08 18:33 ` Stefan Beller [this message] 2018-01-06 18:46 ` [PATCH 2/8] Doc/gitsubmodules: clearly specify advantage of submodule Kaartic Sivaraam 2018-01-08 18:36 ` Stefan Beller 2018-01-09 15:58 ` Kaartic Sivaraam 2018-01-06 18:46 ` [PATCH 3/8] Doc/gitsubmodules: specify how submodules help in reduced size Kaartic Sivaraam 2018-01-07 0:31 ` Eric Sunshine 2018-01-08 18:38 ` Stefan Beller 2018-01-09 16:01 ` Kaartic Sivaraam 2018-01-09 19:01 ` Stefan Beller 2018-01-09 19:30 ` Kaartic Sivaraam 2018-01-06 18:46 ` [PATCH 4/8] Doc/gitsubmodules: avoid abbreviations Kaartic Sivaraam 2018-01-07 0:36 ` Eric Sunshine 2018-01-08 18:45 ` Stefan Beller 2018-01-09 16:06 ` Kaartic Sivaraam 2018-01-09 19:26 ` Stefan Beller 2018-01-09 19:32 ` Kaartic Sivaraam 2018-01-06 18:46 ` [PATCH 5/8] Doc/gitsubmodules: use "Git directory" consistently Kaartic Sivaraam 2018-01-07 0:39 ` Eric Sunshine 2018-01-08 18:45 ` Stefan Beller 2018-01-06 18:46 ` [PATCH 6/8] Doc/gitsubmodules: improve readability of certain lines Kaartic Sivaraam 2018-01-07 0:44 ` Eric Sunshine 2018-01-08 18:49 ` Stefan Beller 2018-01-09 16:37 ` Kaartic Sivaraam 2018-01-09 19:31 ` Stefan Beller 2018-01-09 19:57 ` Kaartic Sivaraam 2018-01-06 18:46 ` [PATCH 7/8] Doc/git-submodule: improve readability and grammar of a sentence Kaartic Sivaraam 2018-01-08 18:57 ` Stefan Beller 2018-01-06 18:46 ` [PATCH 8/8] Doc/git-submodule: correctly quote important words Kaartic Sivaraam 2018-01-08 19:08 ` [PATCH 0/8] Doc/submodules: a few updates Stefan Beller 2018-01-09 17:06 ` Kaartic Sivaraam 2018-01-09 18:50 ` Stefan Beller 2018-01-10 6:49 ` [PATCH v2 0/2] " Kaartic Sivaraam 2018-01-10 6:49 ` [PATCH v2 1/2] Doc/gitsubmodules: make some changes to improve readability and syntax Kaartic Sivaraam 2018-01-10 20:49 ` Stefan Beller 2018-01-10 6:49 ` [PATCH v2 2/2] Doc/git-submodule: improve readability and grammar of a sentence Kaartic Sivaraam 2018-01-14 17:37 ` [PATCH v3 0/2] Doc/submodules: a few updates Kaartic Sivaraam 2018-01-14 17:37 ` [PATCH v3 1/2] Doc/gitsubmodules: make some changes to improve readability and syntax Kaartic Sivaraam 2018-01-16 20:03 ` Stefan Beller 2018-01-14 17:37 ` [PATCH v3 2/2] Doc/git-submodule: improve readability and grammar of a sentence Kaartic Sivaraam 2018-01-16 20:02 ` [PATCH v3 0/2] Doc/submodules: a few updates Junio C Hamano 2018-01-17 2:45 ` Kaartic Sivaraam
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGZ79kaNujhXPPSHQZuvEAz_NLDT0Opna+W4b84-vnan-1UsOA@mail.gmail.com \ --to=sbeller@google.com \ --cc=git@vger.kernel.org \ --cc=kaartic.sivaraam@gmail.com \ --cc=sunshine@sunshineco.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git