From: Stefan Beller <sbeller@google.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Paul Tan <pyokagan@gmail.com>
Subject: Re: [PATCH v2] am: add am.signoff add config variable
Date: Wed, 28 Dec 2016 11:24:13 -0800 [thread overview]
Message-ID: <CAGZ79kaNd2EAjRC=U3_mXB2Deo4oBcUfBHWXPSDfa-vUtBogkg@mail.gmail.com> (raw)
In-Reply-To: <20161228191928.GH3441@thinpad.lan.raisama.net>
On Wed, Dec 28, 2016 at 11:19 AM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Wed, Dec 28, 2016 at 05:11:42PM -0200, Eduardo Habkost wrote:
>> On Wed, Dec 28, 2016 at 10:51:28AM -0800, Stefan Beller wrote:
>> > On Wed, Dec 28, 2016 at 10:35 AM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> [...]
>> > > + test $(git cat-file commit HEAD | grep -c "Signed-off-by:") -eq 0
>> >
>> > and then we check if the top most commit has zero occurrences
>> > for lines grepped for sign off. That certainly works, but took me a
>> > while to understand (TIL about -c in grep :).
>> >
>> > Another way that to write this check, that Git regulars may be more used to is:
>> >
>> > git cat-file commit HEAD | grep "Signed-off-by:" >actual
>> > test_must_be_empty actual
>>
>> test_must_be_empty is what I was looking for. But if I do this:
>>
>> test_expect_success '--no-signoff overrides am.signoff' '
>> rm -fr .git/rebase-apply &&
>> git reset --hard first &&
>> test_config am.signoff true &&
>> git am --no-signoff <patch2 &&
>> printf "%s\n" "$signoff" >expected &&
>> git cat-file commit HEAD^ | grep "Signed-off-by:" >actual &&
>> test_cmp expected actual &&
>> git cat-file commit HEAD | grep "Signed-off-by:" >actual &&
>> test_must_be_empty actual
>> '
>>
>> The test fails because the second "grep" command returns a
>> non-zero exit code. Any suggestions to avoid that problem in a
>> more idiomatic way?
>
> I just found out that "test_must_fail grep ..." is a common
> idiom, so what about:
Uh, no please.
test_must_fail is supposed to be used for commands to be tested, i.e.
git commands as this is the git test suite. :)
test_must_fail checks, e.g. that the failing command "properly" fails
instead of bye-bye-segfault. And grep would never do this. (In this
world we assume everything to be perfect except git itself)
For grep just use !
git cat-file commit HEAD >actual &&
! grep "Signed-off-by:" actual
$ git grep "test_must_fail grep" returns 20 occurrences, so in case you're
that would be a good cleanup patch (if you're interested in such things).
Thanks,
Stefan
next prev parent reply other threads:[~2016-12-28 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 18:35 [PATCH v2] am: add am.signoff add config variable Eduardo Habkost
2016-12-28 18:51 ` Stefan Beller
2016-12-28 19:11 ` Eduardo Habkost
2016-12-28 19:19 ` Eduardo Habkost
2016-12-28 19:24 ` Stefan Beller [this message]
2016-12-29 7:59 ` Pranit Bauva
2016-12-29 15:37 ` Eduardo Habkost
2016-12-28 19:07 ` Andreas Schwab
2016-12-28 19:12 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kaNd2EAjRC=U3_mXB2Deo4oBcUfBHWXPSDfa-vUtBogkg@mail.gmail.com' \
--to=sbeller@google.com \
--cc=ehabkost@redhat.com \
--cc=git@vger.kernel.org \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).