mailing list mirror (one of many)
 help / Atom feed
From: Stefan Beller <>
To: Prathamesh Chavan <>
Cc: "" <>,
	Christian Couder <>,
	Junio C Hamano <>
Subject: Re: [PATCH v1] dir: create function count_slashes
Date: Sun, 11 Jun 2017 22:33:07 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Jun 8, 2017 at 11:08 AM, Prathamesh Chavan <> wrote:
> Similar functions exist in apply.c and builtin/show-branch.c for
> counting the number of slashes in a string. Also in the later
> patches, we introduce a third caller for the same. Hence, we unify
> it now by cleaning the existing functions and declaring a common
> function count_slashes in dir.h and implementing it in dir.c to
> remove this code duplication.
> Mentored-by: Christian Couder <>
> Mentored-by: Stefan Beller <>
> Signed-off-by: Junio C Hamano <>
> Signed-off-by: Prathamesh Chavan <>
> ---
> In future, I intend to use this function in builtin/submodule--helper.c
> as well, hence this change was introduced now.

Thanks for upstreaming this early!

I think this is a good change even
without the submodule work thrown into the soup as well,
but with the given promise to have it used a third time this
is a no-brainer later on.

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 18:08 Prathamesh Chavan
2017-06-12  5:33 ` Stefan Beller [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox