From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jens Lehmann <Jens.Lehmann@web.de>,
Jonathan Nieder <jrnieder@gmail.com>,
Per Cederqvist <cederp@opera.com>
Subject: Re: [PATCH] submodule deinit: require '--all' instead of '.' for all submodules
Date: Tue, 3 May 2016 16:02:27 -0700 [thread overview]
Message-ID: <CAGZ79kaHs6TgxQpPUOKA7NQ8k0r80RrGg7aTtxN90FXwLBsVeA@mail.gmail.com> (raw)
In-Reply-To: <xmqqoa8mkb4l.fsf@gitster.mtv.corp.google.com>
On Tue, May 3, 2016 at 3:52 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> So eventually (i.e. after the submodule groups lands)
>> "submodule deinit ." will start acting weird again?
>
> It would be nice if it never acts in a weird way, but that is all
> future development, not related to this fix, no?
Yes, just this patch is fine. Though lacking documentation.
I'll send an update.
next prev parent reply other threads:[~2016-05-03 23:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 22:11 [PATCH] submodule deinit: require '--all' instead of '.' for all submodules Stefan Beller
2016-05-03 22:25 ` Junio C Hamano
2016-05-03 22:28 ` Junio C Hamano
2016-05-03 22:43 ` Stefan Beller
2016-05-03 22:52 ` Junio C Hamano
2016-05-03 23:02 ` Stefan Beller [this message]
2016-05-04 0:33 ` [PATCHv2] " Stefan Beller
2016-05-04 0:47 ` Jonathan Nieder
2016-05-04 1:19 ` [PATCHv3] " Stefan Beller
2016-05-04 20:44 ` Junio C Hamano
2016-05-04 21:34 ` Stefan Beller
2016-05-04 21:43 ` Junio C Hamano
2016-05-04 21:47 ` Stefan Beller
2016-05-04 21:51 ` Junio C Hamano
2016-05-04 21:49 ` Junio C Hamano
2016-05-04 21:57 ` Stefan Beller
2016-05-04 22:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kaHs6TgxQpPUOKA7NQ8k0r80RrGg7aTtxN90FXwLBsVeA@mail.gmail.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=cederp@opera.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).