From: Stefan Beller <sbeller@google.com>
To: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH 1/2] submodule-config: keep shallow recommendation around
Date: Thu, 26 May 2016 10:22:27 -0700 [thread overview]
Message-ID: <CAGZ79kaFD=0ijNvs8B9V+KbhasqF1N6OoAVucR-Hf_hVN+b-dQ@mail.gmail.com> (raw)
In-Reply-To: <2022441346.44059.1464253372857.JavaMail.zimbra@ensimag.grenoble-inp.fr>
On Thu, May 26, 2016 at 2:02 AM, Remi Galan Alfonso
<remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote:
> Hi Stefan,
>
> Stefan Beller <sbeller@google.com> writes:
>> [...]
>> @ -353,6 +354,15 @@ static int parse_config(const char *var, const char *value, void *data)
>> else if (parse_submodule_update_strategy(value,
>> &submodule->update_strategy) < 0)
>> die(_("invalid value for %s"), var);
>> + } else if (!strcmp(item.buf, "shallow")) {
>> + if (!me->overwrite &&
>> + submodule->recommend_shallow != -1)
>
> Nit: You seems to be able to keep the whole condition on the same line:
>
> if (!me->overwrite && submodule->recommend_shallow != -1)
>
> If you want to keep it in two line, you might want to align it:
> if (!me->overwrite &&
> submodule->recommend_shallow != -1)
Thanks will fix!
>
> Thanks,
> Rémi
next prev parent reply other threads:[~2016-05-26 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 0:06 [PATCHv2 0/2] Submodule shallow recommendation [WAS: Submodules: have a depth field in the .gitmodules file] Stefan Beller
2016-05-26 0:06 ` [PATCH 1/2] submodule-config: keep shallow recommendation around Stefan Beller
2016-05-26 9:02 ` Remi Galan Alfonso
2016-05-26 17:22 ` Stefan Beller [this message]
2016-05-26 0:06 ` [PATCH 2/2] submodule update: learn `--[no-]recommend-shallow` option Stefan Beller
2016-05-26 9:07 ` Remi Galan Alfonso
2016-05-26 17:29 ` Stefan Beller
2016-05-26 18:13 ` [PATCHv2 0/2] Submodule shallow recommendation [WAS: Submodules: have a depth field in the .gitmodules file] Junio C Hamano
2016-05-26 18:54 ` Stefan Beller
2016-05-26 19:16 ` Junio C Hamano
2016-05-26 21:20 ` Stefan Beller
-- strict thread matches above, loose matches on Subject: below --
2016-05-26 21:59 [PATCHv3 " Stefan Beller
2016-05-26 21:59 ` [PATCH 1/2] submodule-config: keep shallow recommendation around Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kaFD=0ijNvs8B9V+KbhasqF1N6OoAVucR-Hf_hVN+b-dQ@mail.gmail.com' \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).