Feature Request: option for git difftool to show changes in submodule contents

Feature Request: option for git difftool to show changes in submodule contents

[Oshaben Nicholas]

Hello, 

A coworker of mine was trying to use git difftool in a repository with submodules and we found that it only shows the change in the subproject commit hash. The option to show the changes in the contents of the submodules exists for git diff. Can this be added to difftool as well?

Thank you,

Nicholas Oshaben
nicholas.oshaben@bwigroup.com

Re: Feature Request: option for git difftool to show changes in submodule contents

[Stefan Beller]

Hi Oshaben!

On Mon, Apr 23, 2018 at 7:49 AM, Oshaben Nicholas
<nicholas.oshaben@bwigroup.com> wrote:
> Hello,
>
> A coworker of mine was trying to use git difftool in a repository with submodules and we found that it only shows the change in the subproject commit hash. The option to show the changes in the contents of the submodules exists for git diff. Can this be added to difftool as well?

Yes, of course it can be added. Care to write a patch?

See lines 432-443 in builtin/difftool.c:
https://github.com/git/git/blob/master/builtin/difftool.c#L432

I'd think you'd want to compute some output
(Similar to the git-diff output? Then we could just
refactor the submodule diff stuff to be reusable here)
and put it into the strbuf there.

Feel free to ask away or read the docs Documentation/SubmittingPatches

Thanks,
Stefan