git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Derrick Stolee <dstolee@microsoft.com>, git <git@vger.kernel.org>,
	Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH 2/2] refs.c: upgrade for_each_replace_ref to be a each_repo_ref_fn callback
Date: Wed, 18 Jul 2018 10:07:33 -0700	[thread overview]
Message-ID: <CAGZ79kZyWWivaVgdCt-Zf-_3p9L5fis7ZC73pwDEGNQUfc8f+Q@mail.gmail.com> (raw)
In-Reply-To: <6c74aee8-2e18-99de-f775-dced1310809f@gmail.com>

Hi Derrick,

> Overall, I think this is the right approach. The only problem is that
> you're missing a few 'the_repository' to 'r' replacements in the bodies
> of show_reference and register_replace_ref.

Thanks.

Originally I had another approach, which was to convert all
callbacks to take a repository argument, and only if the refs
backend learned to propagate the correct repository the repo
argument would be the specific repo, NULL otherwise.

With that approach it was not possible to replace all occurrences
of the_repository with 'r', and it would also be confusing.

But as I pursued that approach at the time of writing this patch...
I missed the conversions needed.

Thanks for catching them (and fixing them in the reroll that
you just sent out via gitgitgadget)!

Thanks,
Stefan

  reply	other threads:[~2018-07-18 17:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 22:49 [PATCH 0/2] RFC ref store to repository migration Stefan Beller
2018-07-17 22:49 ` [PATCH 1/2] refs.c: migrate internal ref iteration to pass thru repository argument Stefan Beller
2018-07-17 22:49 ` [PATCH 2/2] refs.c: upgrade for_each_replace_ref to be a each_repo_ref_fn callback Stefan Beller
2018-07-18 10:58   ` Derrick Stolee
2018-07-18 17:07     ` Stefan Beller [this message]
2018-07-18 13:40   ` [PATCH] TO-SQUASH: replace the_repository with arbitrary r Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79kZyWWivaVgdCt-Zf-_3p9L5fis7ZC73pwDEGNQUfc8f+Q@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).