git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Sebastian Schuberth <sschuberth@gmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Fwd: Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD
Date: Tue, 18 Apr 2017 12:12:13 -0700	[thread overview]
Message-ID: <CAGZ79kZy1rBUaF1XbUOPUxDPzT1FwCp92jbbiO4RX3aiCoNkxQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kazh5+6vx87PVXUNgyJebO2m6pEkT1G8rSFvCmWQZdSuw@mail.gmail.com>

On Tue, Apr 18, 2017 at 6:04 AM, Sebastian Schuberth
<sschuberth@gmail.com> wrote:
> Hi,
>
> this is using "git version 2.12.2.windows.2" on Windows / "git version 2.12.2-639-g584f897" on Linux.
>
> I have configured my superproject with .gitmodules saying
>
> ---8<---
> [submodule "src/funTest/resources/projects/external/jgnash"]
>        path = src/funTest/resources/projects/external/jgnash
>        url = https://github.com/ccavanaugh/jgnash.git
>        shallow = true
> ---8<---
>
> and configured the submodule to checkout commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 [1]. When doing a fresh clone of my superproject via "git clone --recursive" I get
>
> ---8<---
> error: Server does not allow request for unadvertised object 2aa4cce7d7fd46164030f2b4d244c4b89e77f722
> Fetched in submodule path 'src/funTest/resources/projects/external/jgnash', but it did not contain 2aa4cce7d7fd464030f2b4d244c4b89e77f722. Direct fetching of that commit failed.
> ---8<---
>
> So far so good, it simply seems that GitHub does not support allowReachableSHA1InWant [2].

Maybe the error message should say so: "Bug your host admin to enable
allowReachableSHA1InWant".

> The interesting bit is that my submodule checkout still ends up being shallow, but poiting to HEAD:
>
> ---8<---
> $ cd src/funTest/resources/projects/external/jgnash
> $ git log
> commit 12036fffb6c620515edd96416363fd1749b5d003 (grafted, HEAD -> master, origin/master, origin/HEAD)
> Author: Craig Cavanaugh <jgnash.devel@gmail.com>
> Date:   Tue Apr 18 05:33:06 2017 -0400
>
>     Fix typos
> ---8<---
>
> Wouldn't it make more sense to unshallow the submodule clone in this case and checkout the configured commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 afterwards?

If I remember correctly the conclusion of the discussion at the time
was that people are more interested in "less data" rather than
"correct data" because otherwise you would not have asked for shallow.

> At least I'd be getting what I asked for in that case, even if at the cost of additional network traffic. Because if I read [3] correctly, the command line option belonging to "submodule.<name>.shallow" is called "--[no-]recommend-shallow", i.e. it's only a recommendation, to falling back to a full clone should be fine.

Heh, good point. Currently that option is more like a
"--[no-]follow-shallow-in-gitmodules" without second thought as the
"recommend" would elude to.

Thanks,
Stefan

>
> [1] https://github.com/ccavanaugh/jgnash/commit/2aa4cce7d7fd46164030f2b4d244c4b89e77f722
> [2] https://git-scm.com/docs/git-config#git-config-uploadpackallowReachableSHA1InWant
> [3] https://git-scm.com/docs/git-submodule
>
> Regards,
> Sebastian
>

  parent reply	other threads:[~2017-04-18 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 13:04 Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD Sebastian Schuberth
     [not found] ` <CAGZ79kazh5+6vx87PVXUNgyJebO2m6pEkT1G8rSFvCmWQZdSuw@mail.gmail.com>
2017-04-18 19:12   ` Stefan Beller [this message]
2017-04-18 19:18     ` Fwd: " Sebastian Schuberth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79kZy1rBUaF1XbUOPUxDPzT1FwCp92jbbiO4RX3aiCoNkxQ@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=sschuberth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).