From: Stefan Beller <sbeller@google.com>
To: Jeremy Morton <admin@game-point.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Allow git alias to override existing Git commands
Date: Tue, 10 Nov 2015 10:12:45 -0800 [thread overview]
Message-ID: <CAGZ79kZxQWVMe3N1ti8npyp9_4DUPAVy9Uk5a75Jwh3Eud2eZQ@mail.gmail.com> (raw)
In-Reply-To: <56421BD9.5060501@game-point.net>
On Tue, Nov 10, 2015 at 8:31 AM, Jeremy Morton <admin@game-point.net> wrote:
> It's recently come to my attention that the "git alias" config functionality
> ignores all aliases that would override existing Git commands. This seems
> like a bad idea to me.
This ensures that the plumbing commands always work as expected.
As scripts *should* only use plumbing commands, the scripts should
work with high probability despite all the crazy user configuration/aliases.
>
> For example, I wanted to setup "git clone" to automatically act as "git
> clone --recursive". Sure I could do it in the shell, but it's more of a
> pain - any tutorial I set up about doing it would have to worry about what
> shell the user was using - and if you're going to make that argument, why
> have "git alias" at all? It can all be done from the shell.
I think the git way for your example would be to configure git to include that
option by default, something like
git config --global submodules.recursiveClone yes
though I was skimming through the man page of git config and did not find
that option there. I guess it's missing.
>
> Obviously I could also use a different alias that wasn't an existing Git
> command for this behaviour, but that would rather defeat the point: I want
> "git clone" to have different functionality. If I remembered to use a
> different Git command, I might as well remember to type "git clone
> --recursive". Also, if a future Git command were introduced with the same
> name as my alias, my alias's functionality would suddenly be ignored, giving
> unexpected behaviour.
>
> The reasoning behind this that it's "to avoid confusion and troubles with
> script usage" seems to be at odds with the general Git mentality that the
> user is given lots of power, and if they screw it up it's basically just
> user error.
For scripting the plumbing commands are recommended. The plumbing commands
usually cannot be configured to do crazy stuff.
> For example, Git doesn't *have* to allow you to rebase. It's a
> potentially dangerous operation, so why is it allowed? It might "cause
> confusion and troubles".
Git doesn't try to hide its complexity from the users. And if a user would need
to hack their way around to get rebasing working again, might also
"cause confusion
and troubles".
>
> On the other hand, by disallowing the overriding of existing Git commands
> through aliases you are preventing a lot of useful functionality that those
> aliases might be used for.
>
> So I think you should either allow Git aliases to override existing Git
> commands by default, or at least provide a config option that allows the
> user to say that this should happen.
>
> --
> Best regards,
> Jeremy Morton (Jez)
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-10 18:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 16:31 Allow git alias to override existing Git commands Jeremy Morton
2015-11-10 18:12 ` Stefan Beller [this message]
2015-11-10 20:04 ` Jeremy Morton
2015-11-10 20:22 ` Stefan Beller
2015-11-11 4:48 ` Sitaram Chamarty
2015-11-11 9:28 ` Jeremy Morton
2015-11-11 9:51 ` Sitaram Chamarty
2015-11-11 10:12 ` Jeremy Morton
2015-11-11 10:45 ` Sitaram Chamarty
2015-11-11 17:42 ` Stefan Beller
2015-11-10 21:57 ` Jens Lehmann
2015-11-10 22:49 ` Stefan Beller
2015-11-11 19:44 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZxQWVMe3N1ti8npyp9_4DUPAVy9Uk5a75Jwh3Eud2eZQ@mail.gmail.com \
--to=sbeller@google.com \
--cc=admin@game-point.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).