mailing list mirror (one of many)
 help / Atom feed
From: Stefan Beller <>
To: Jonathan Nieder <>
Cc: Junio C Hamano <>,
	"" <>
Subject: Re: [PATCH] recursive submodules: detach HEAD from new state
Date: Tue, 21 Nov 2017 14:45:30 -0800
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Nov 21, 2017 at 2:34 PM, Jonathan Nieder <> wrote:
> Stefan Beller wrote:
>>> Junio C Hamano <> writes:
>>>> Also, while I do agree with you that the problem exists, it is
>>>> unclear why this patch is a solution and not a hack that sweeps a
>>>> problem under the rug.
>>>> It is unclear why this "silently detach HEAD without telling the
>>>> user" is a better solution than erroring out, for example [*1*].
> [...]
>> So I took a step back and wrote about different proposals where
>> we want to go long term. See below. This will help us
>> figuring out how to approach this bug correctly.
> Stefan, do you know what thread I should look at to find the current
> state of this patch?  I've had it applied locally for a long time.

It was "Undecided" for some time, then Junio kicked it back to pu, expecting a
reroll[1]. The "send out a plan" that was referenced is found in [2]
describing 6
plans for the future of submodules. The approach in [3] which is
different on the
implementation level, but very similar on the UX level sounds best currently.
I'll coordinate with JTan to come up with patches for that.


> The thread I am replying to appears to be where the patch comes from
> but I have some memories of more recent discussion that I'm not
> finding.
> More context:
> says
>  * sb/submodule-recursive-checkout-detach-head (2017-07-28) 2 commits
>   - Documentation/checkout: clarify submodule HEADs to be detached
>   - recursive submodules: detach HEAD from new state
>   "git checkout --recursive" may overwrite and rewind the history of
>   the branch that happens to be checked out in submodule
>   repositories, which might not be desirable.  Detach the HEAD but
>   still allow the recursive checkout to succeed in such a case.
>   Expecting a reroll.
> Thanks,
> Jonathan

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 17:36 Stefan Beller
2017-07-24 18:03 ` Jonathan Nieder
2017-07-24 19:07   ` Stefan Beller
2017-07-24 20:57     ` Junio C Hamano
2017-07-24 21:33   ` Junio C Hamano
2017-07-24 22:23     ` Junio C Hamano
2017-07-25 22:27       ` Stefan Beller
2017-07-26 19:36         ` Junio C Hamano
2017-11-21 22:34         ` Jonathan Nieder
2017-11-21 22:45           ` Stefan Beller [this message]
2017-11-21 22:47             ` Jonathan Nieder
2017-11-21 23:00               ` Stefan Beller
2017-11-22  0:54           ` Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox