git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Norio Nomura <norio.nomura@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [BUG] `git submodule update --init --recursive` stores gitdir in full path into `.git` of nested submodules
Date: Wed, 30 Mar 2016 10:24:25 -0700	[thread overview]
Message-ID: <CAGZ79kZwSFjADYYC=FBFr8cWv08mv+H7E=Bx3N=J2Q_o8sK9qw@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kaa2uBmRZ_OPG9hVkrc29uj8Lx9b-6fgbcDNE0OGvJ+cg@mail.gmail.com>

On Wed, Mar 30, 2016 at 9:05 AM, Stefan Beller <sbeller@google.com> wrote:
> On Wed, Mar 30, 2016 at 2:03 AM, Norio Nomura <norio.nomura@gmail.com> wrote:
>> Hi,
>>
>> `git submodule update --init --recursive` stores `gitdir` in full path into `.git` of nested submodules.
>> So, working directory is not portable to another directory.
>
> Are you reporting a regression bug? (Is that a new thing or has it
> always been that way and you just discover that it is unfortunate?)
> Which versions did you test with?

➜  15:34:32 git:(master) git --version
git version 2.8.0

at the end of your gist.
The same happens when using 2.7.4, it doesn't happen when using 2.6.6 though.

It turns out ee8838d (2015-09-08, submodule: rewrite `module_clone`
shell function in C)
broke it.

I'll look into fixing it.

Thanks,
Stefan


>
>>
>> On following example, `Carthage/Checkouts/Quick/Externals/Nimble/` is nested submodule and `Carthage/Checkouts/Quick/Externals/Nimble/.git` contains full path.
>> https://gist.github.com/norio-nomura/17ce4bdf0151185e77d9b1fcfb5a469d
>>
>> Thanks,
>> --
>> Norio Nomura @norio_nomura
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-03-30 17:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  9:03 [BUG] `git submodule update --init --recursive` stores gitdir in full path into `.git` of nested submodules Norio Nomura
2016-03-30 16:05 ` Stefan Beller
2016-03-30 17:24   ` Stefan Beller [this message]
2016-03-30 20:54     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGZ79kZwSFjADYYC=FBFr8cWv08mv+H7E=Bx3N=J2Q_o8sK9qw@mail.gmail.com' \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=norio.nomura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).