From: Stefan Beller <sbeller@google.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] submodule: mark a file-local symbol as static
Date: Thu, 11 Aug 2016 13:13:06 -0700 [thread overview]
Message-ID: <CAGZ79kZw2E8GDLBvs9MRW90ny8AnszxOcV2yVM8+r2y_sE3=og@mail.gmail.com> (raw)
In-Reply-To: <322d7d47-423c-f631-3057-1feb03d50591@ramsayjones.plus.com>
On Thu, Aug 11, 2016 at 12:57 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-clone-rr' branch, could
> you please squash this into the relevant patch (commit 336c21d,
> "submodule: try alternates when superproject has an alternate",
> 08-08-2016).
Not just reroll but rethink and rewrite. ;)
Thanks for catching!
Stefan
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> builtin/submodule--helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index 4c765e1..4c7d03c 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -641,7 +641,7 @@ struct submodule_alternate_setup {
> struct strbuf *out;
> };
>
> -int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)
> +static int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)
> {
> struct submodule_alternate_setup *sas = sas_cb;
>
> --
> 2.9.0
next prev parent reply other threads:[~2016-08-11 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 19:57 [PATCH] submodule: mark a file-local symbol as static Ramsay Jones
2016-08-11 20:13 ` Stefan Beller [this message]
2016-08-13 14:31 Ramsay Jones
2016-08-15 19:07 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kZw2E8GDLBvs9MRW90ny8AnszxOcV2yVM8+r2y_sE3=og@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).