* Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
@ 2017-06-27 13:16 Robert Siemer
2017-06-27 15:06 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Robert Siemer @ 2017-06-27 13:16 UTC (permalink / raw)
To: git@vger.kernel.org
Hello everyone,
$ git submodule foreach cat .git
...shows that the gitdir registered in the .git file of submodules is relative. But if you run
$ git submodule foreach --recursive cat .git
...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
1) Can you confirm that behavior?
2) Am I right that this is a bug (at least because of inconsistency)?
Regards,
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
2017-06-27 13:16 Bug: submodules of submodules use absolute gitdir in .git file (instead of relative) Robert Siemer
@ 2017-06-27 15:06 ` Junio C Hamano
2017-06-27 17:35 ` Stefan Beller
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2017-06-27 15:06 UTC (permalink / raw)
To: Robert Siemer; +Cc: git@vger.kernel.org
Robert Siemer <Robert.Siemer@rohde-schwarz.com> writes:
> Hello everyone,
>
> $ git submodule foreach cat .git
>
> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run
>
> $ git submodule foreach --recursive cat .git
>
> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
>
> 1) Can you confirm that behavior?
Nobody can without knowing which version of Git you are using. I
suspect that we had discussed and addressed something related to
nested submodule's "gitdir" pointer in not-so-distant past.
> 2) Am I right that this is a bug (at least because of inconsistency)?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
2017-06-27 15:06 ` Junio C Hamano
@ 2017-06-27 17:35 ` Stefan Beller
[not found] ` <a882773a8f0f4632a204090baa0f182b@rohde-schwarz.com>
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Beller @ 2017-06-27 17:35 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Robert Siemer, git@vger.kernel.org
On Tue, Jun 27, 2017 at 8:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Robert Siemer <Robert.Siemer@rohde-schwarz.com> writes:
>
>> Hello everyone,
>>
>> $ git submodule foreach cat .git
>>
>> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run
>>
>> $ git submodule foreach --recursive cat .git
>>
>> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
>>
>> 1) Can you confirm that behavior?
>
> Nobody can without knowing which version of Git you are using. I
> suspect that we had discussed and addressed something related to
> nested submodule's "gitdir" pointer in not-so-distant past.
Yeah there was a period in time where we had this bug.
(Or is it a different bug?)
See 90c0011619 (submodule: use absolute path for computing
relative path connecting, 2016-12-08), which is included in 2.12.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
[not found] ` <a882773a8f0f4632a204090baa0f182b@rohde-schwarz.com>
@ 2017-06-28 12:30 ` Robert Siemer
0 siblings, 0 replies; 4+ messages in thread
From: Robert Siemer @ 2017-06-28 12:30 UTC (permalink / raw)
To: Stefan Beller, Junio C Hamano; +Cc: git@vger.kernel.org
I had the problem with version 2.7.4.
The problem is fixed in self-compiled v2.13.2.533.ge0aaa1bed, v2.12.0, v2.11.0 and v2.9.3! Even the older version 2.1.4 does not have that problem.
Thank you for the input!
Robert
________________________________________
From: Siemer Robert CSNPE
Sent: Wednesday, June 28, 2017 14:09
To: Stefan Beller; Junio C Hamano
Cc: git@vger.kernel.org
Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
________________________________________
From: Stefan Beller <sbeller@google.com>
Sent: Tuesday, June 27, 2017 19:35
To: Junio C Hamano
Cc: Siemer Robert CSNPE; git@vger.kernel.org
Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
On Tue, Jun 27, 2017 at 8:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Robert Siemer <Robert.Siemer@rohde-schwarz.com> writes:
>
>> Hello everyone,
>>
>> $ git submodule foreach cat .git
>>
>> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run
>>
>> $ git submodule foreach --recursive cat .git
>>
>> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
>>
>> 1) Can you confirm that behavior?
>
> Nobody can without knowing which version of Git you are using. I
> suspect that we had discussed and addressed something related to
> nested submodule's "gitdir" pointer in not-so-distant past.
Yeah there was a period in time where we had this bug.
(Or is it a different bug?)
See 90c0011619 (submodule: use absolute path for computing
relative path connecting, 2016-12-08), which is included in 2.12.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-28 12:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 13:16 Bug: submodules of submodules use absolute gitdir in .git file (instead of relative) Robert Siemer
2017-06-27 15:06 ` Junio C Hamano
2017-06-27 17:35 ` Stefan Beller
[not found] ` <a882773a8f0f4632a204090baa0f182b@rohde-schwarz.com>
2017-06-28 12:30 ` Robert Siemer
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).