From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Robert Siemer <Robert.Siemer@rohde-schwarz.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
Date: Tue, 27 Jun 2017 10:35:15 -0700 [thread overview]
Message-ID: <CAGZ79kZmV9Aufrsmf1iohhP5qHzA4AZ3DDv8sn1GMaCZ+SbV5Q@mail.gmail.com> (raw)
In-Reply-To: <xmqqr2y531xv.fsf@gitster.mtv.corp.google.com>
On Tue, Jun 27, 2017 at 8:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Robert Siemer <Robert.Siemer@rohde-schwarz.com> writes:
>
>> Hello everyone,
>>
>> $ git submodule foreach cat .git
>>
>> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run
>>
>> $ git submodule foreach --recursive cat .git
>>
>> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
>>
>> 1) Can you confirm that behavior?
>
> Nobody can without knowing which version of Git you are using. I
> suspect that we had discussed and addressed something related to
> nested submodule's "gitdir" pointer in not-so-distant past.
Yeah there was a period in time where we had this bug.
(Or is it a different bug?)
See 90c0011619 (submodule: use absolute path for computing
relative path connecting, 2016-12-08), which is included in 2.12.
next prev parent reply other threads:[~2017-06-27 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 13:16 Bug: submodules of submodules use absolute gitdir in .git file (instead of relative) Robert Siemer
2017-06-27 15:06 ` Junio C Hamano
2017-06-27 17:35 ` Stefan Beller [this message]
[not found] ` <a882773a8f0f4632a204090baa0f182b@rohde-schwarz.com>
2017-06-28 12:30 ` Robert Siemer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZmV9Aufrsmf1iohhP5qHzA4AZ3DDv8sn1GMaCZ+SbV5Q@mail.gmail.com \
--to=sbeller@google.com \
--cc=Robert.Siemer@rohde-schwarz.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).