Re: [PATCH v4 04/11] replace: "libify" create_graft() and callees

[Stefan Beller <sbeller@google.com>]

Hi Johannes,

On Tue, Apr 24, 2018 at 11:51 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:

>
> Oy vey. How many more mistakes can I introduce in one commit...
>

I ask this myself all the time, but Software is hard when not having
computer assisted checks. The test suite doesn't quite count here,
as it doesn't yell loudly enough for leaks in corner cases.

Thanks for taking these seriously, I was unsure if the
first issues (close() clobbering the errno) were sever enough
to bother. It complicates the code, but the effect is theoretical)
(for EBADF) or a real niche corner case (EINTR).

Speaking of that, I wonder if we eventually want to have
a wrapper

int xclose(int fd)
{
    int err = errno;
    int ret = close(fd)
    if (errno == EINTR)
        /* on linux we don't care about this, other OSes? */
        ;
    errno = err;
    return ret;
}

Though not in this series.

Thanks,
Stefan