From: Stefan Beller <sbeller@google.com>
To: Valery Tolstov <me@vtolstov.org>
Cc: sven@cs-ware.de, "git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: git init --separate-git-dir does not update symbolic .git links for submodules
Date: Mon, 6 Mar 2017 08:40:46 -0800 [thread overview]
Message-ID: <CAGZ79kZbc394rmxYDUxCbysKNbEQCB7aLJkf6MGcCeXKAxiKhA@mail.gmail.com> (raw)
In-Reply-To: <1488636950.25023.2@smtp.yandex.ru>
On Sat, Mar 4, 2017 at 6:15 AM, Valery Tolstov <me@vtolstov.org> wrote:
> Looking for microproject ideas for GSoC.
> Would this issue be suitable as the microproject?
It would be a good project, but not as 'micro' I would assume. ;)
Why it is not a micro project:
To fix this issue we'd want to fix the .git link files recursively, i.e.
nested submodules would also need fixing. And to recurse into
submodules we normally spawn a child process.
So maybe the plan is as follow:
1) Add the functionality to builtin/submodule--helper.c
it fixes just one submodule, given by name.
2) add an externally visible command in the same file
See e.g. module_name (the function and the table
at the very end of the file)
(1) needs to call this command (see clone_submodule() in
that file how to call further commands)
2) "git init --separate-git-dir ../test" would call the function
in (1), which then recursively uses (2) to call (1) in nested
submodules.
After thinking about it, it may be good for a micro project,
as it is smaller than originally assumed.
Specifically if you plan to look into submodules later on.
Thanks,
Stefan
next prev parent reply other threads:[~2017-03-06 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 14:15 git init --separate-git-dir does not update symbolic .git links for submodules Valery Tolstov
2017-03-06 16:40 ` Stefan Beller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-07 19:52 Valery Tolstov
2017-03-07 20:11 ` Stefan Beller
2017-03-07 18:59 Valery Tolstov
2017-03-07 19:59 ` Stefan Beller
2017-03-04 12:15 Sven Strickroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZbc394rmxYDUxCbysKNbEQCB7aLJkf6MGcCeXKAxiKhA@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@vtolstov.org \
--cc=sven@cs-ware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).