From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Williams <bmwill@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Philip Oakley <philipoakley@iee.org>
Subject: Re: [PATCH 2/3] builtin/fetch: parse recurse-submodules-default at default options parsing
Date: Mon, 26 Jun 2017 20:00:24 -0700 [thread overview]
Message-ID: <CAGZ79kZUkQCEEcLUcg8tSr33Wng1Fq4_i4n80+Xr45y0mcvB6A@mail.gmail.com> (raw)
In-Reply-To: <xmqq1sqab436.fsf@gitster.mtv.corp.google.com>
On Fri, Jun 23, 2017 at 5:51 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>>> if (recurse_submodules != RECURSE_SUBMODULES_OFF) {
>>>> - if (recurse_submodules_default) {
>>>> - int arg = parse_fetch_recurse_submodules_arg("--recurse-submodules-default", recurse_submodules_default);
>>>> - set_config_fetch_recurse_submodules(arg);
>>>> - }
>>>> + if (recurse_submodules_default != RECURSE_SUBMODULES_DEFAULT)
>>>> + set_config_fetch_recurse_submodules(recurse_submodules_default);
>>>
>
> I am not talking about the outer "if" condition.
I agree with your analysis, my answer was evasive.
I'll dig into the details why we do not set the default by default.
next prev parent reply other threads:[~2017-06-27 3:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 19:12 [PATCH 0/3] pull: optionally rebase submodules Stefan Beller
2017-06-23 19:13 ` [PATCH 1/3] builtin/fetch: factor submodule recurse parsing out to submodule config Stefan Beller
2017-06-23 22:26 ` Junio C Hamano
2017-06-23 19:13 ` [PATCH 2/3] builtin/fetch: parse recurse-submodules-default at default options parsing Stefan Beller
2017-06-23 22:36 ` Junio C Hamano
2017-06-23 22:49 ` Stefan Beller
2017-06-24 0:51 ` Junio C Hamano
2017-06-27 3:00 ` Stefan Beller [this message]
2017-06-27 21:31 ` [PATCH] builtin/fetch cleanup: always set default value for submodule recursing Stefan Beller
2017-06-23 19:13 ` [PATCH 3/3] pull: optionally rebase submodules (remote submodule changes only) Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZUkQCEEcLUcg8tSr33Wng1Fq4_i4n80+Xr45y0mcvB6A@mail.gmail.com \
--to=sbeller@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).