git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Valery Tolstov <me@vtolstov.org>
Cc: Brandon Williams <bmwill@google.com>,
	Christian Couder <christian.couder@gmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [GSoC] Discussion of "Submodule related work" project
Date: Wed, 15 Mar 2017 13:48:41 -0700	[thread overview]
Message-ID: <CAGZ79kZU555GyMNkuED2efep9oYAag_FJ7ETRPH2tvipLO9K4Q@mail.gmail.com> (raw)
In-Reply-To: <20170315204324.9875-1-me@vtolstov.org>

On Wed, Mar 15, 2017 at 1:43 PM, Valery Tolstov <me@vtolstov.org> wrote:
> I have a thought. At the moment when submodule command is already translated
> to C, possibly we want to rename submodule--helper.c, and maybe hide
> some of it's functions from subcommands list. Is there any examples of
> similar situation that already happened before?

I would keep the submodule--helper around as it is
and maybe even promote it to be a "plumbing" command.
Currently it is just an undocumented, internal command.

Once all commands in git-submodule.sh are translated to C
(when they all look similar to "git submodule init", which
is just a relay in the shell script), then we can make a full grown
builtin/submodule.c that calls the functions of the submodule--helper
directly in C.

Stefan

      reply	other threads:[~2017-03-15 20:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 11:27 [GSoC] Discussion of "Submodule related work" project Valery Tolstov
2017-03-10 18:47 ` Stefan Beller
2017-03-10 19:30   ` Valery Tolstov
2017-03-10 21:13     ` Valery Tolstov
2017-03-13 18:24       ` Stefan Beller
2017-03-15 20:43         ` Valery Tolstov
2017-03-15 20:48           ` Stefan Beller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79kZU555GyMNkuED2efep9oYAag_FJ7ETRPH2tvipLO9K4Q@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=bmwill@google.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@vtolstov.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).