From: Stefan Beller <sbeller@google.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 1/3] rebase -i: demonstrate bug with fixup!/squash! commit messages
Date: Fri, 20 Apr 2018 09:40:46 -0700 [thread overview]
Message-ID: <CAGZ79kZONQ_xuDYJ5Z8cUnF0odwz3+Sh+ST6g+5Tefav-QXEBw@mail.gmail.com> (raw)
In-Reply-To: <ad2a1b2c60341d692e94b1cb997df05dd7cded88.1524226637.git.johannes.schindelin@gmx.de>
On Fri, Apr 20, 2018 at 5:17 AM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> When multiple fixup/squash commands are processed and the last one
> causes merge conflicts and is skipped, we leave the "This is a
> combination of ..." comments in the commit message.
>
> Noticed by Eric Sunshine.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> t/t3418-rebase-continue.sh | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/t/t3418-rebase-continue.sh b/t/t3418-rebase-continue.sh
> index 9214d0bb511..b177baee322 100755
> --- a/t/t3418-rebase-continue.sh
> +++ b/t/t3418-rebase-continue.sh
> @@ -88,6 +88,27 @@ test_expect_success 'rebase passes merge strategy options correctly' '
> git rebase --continue
> '
>
> +test_expect_failure '--continue after failed fixup cleans commit message' '
> + git checkout -b with-conflicting-fixup &&
> + test_commit wants-fixup &&
> + test_commit "fixup! wants-fixup" wants-fixup.t 1 wants-fixup-1 &&
> + test_commit "fixup! wants-fixup" wants-fixup.t 2 wants-fixup-2 &&
> + test_commit "fixup! wants-fixup" wants-fixup.t 3 wants-fixup-3 &&
> + test_must_fail env FAKE_LINES="1 fixup 2 fixup 4" \
> + git rebase -i HEAD~4 &&
> +
> + : now there is a conflict, and comments in the commit message &&
> + git show HEAD >out &&
> + grep "This is a combination of" out &&
test_i18n_grep ?
> +
> + : skip and continue &&
> + git rebase --skip &&
> +
> + : now the comments in the commit message should have been cleaned up &&
> + git show HEAD >out &&
> + ! grep "This is a combination of" out
same
Thanks,
Stefan
next prev parent reply other threads:[~2018-04-20 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 12:17 [PATCH 0/3] rebase -i: avoid stale "# This is a combination of" in commit messages Johannes Schindelin
2018-04-20 12:17 ` [PATCH 1/3] rebase -i: demonstrate bug with fixup!/squash! " Johannes Schindelin
2018-04-20 16:40 ` Stefan Beller [this message]
2018-04-20 20:04 ` Johannes Schindelin
2018-04-20 20:38 ` Johannes Schindelin
2018-04-20 20:44 ` Stefan Beller
2018-04-20 21:05 ` Johannes Schindelin
2018-04-20 19:29 ` Eric Sunshine
2018-04-20 19:31 ` Eric Sunshine
2018-04-20 20:52 ` Johannes Schindelin
2018-04-20 12:18 ` [PATCH 2/3] sequencer: leave a tell-tale when a fixup/squash failed Johannes Schindelin
2018-04-20 19:34 ` Eric Sunshine
2018-04-20 12:18 ` [PATCH 3/3] rebase --skip: clean up commit message after a failed fixup/squash Johannes Schindelin
2018-04-21 15:42 ` [PATCH 3/3] rebase --skip: clean up commit message after a failedfixup/squash Phillip Wood
2018-04-27 21:36 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZONQ_xuDYJ5Z8cUnF0odwz3+Sh+ST6g+5Tefav-QXEBw@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).