From: Stefan Beller <sbeller@google.com>
To: Santiago Torres <santiago@nyu.edu>
Cc: Colin Walters <walters@verbum.org>, git <git@vger.kernel.org>
Subject: Re: upstreaming https://github.com/cgwalters/git-evtag ?
Date: Mon, 8 Jan 2018 12:49:01 -0800 [thread overview]
Message-ID: <CAGZ79kZ8AXezcX1_5WJsUJMHiHCzj2B=Uj8+4K3VF+cC6mTCqA@mail.gmail.com> (raw)
In-Reply-To: <20180108204029.m42qyezojak4kohh@LykOS.localdomain>
On Mon, Jan 8, 2018 at 12:40 PM, Santiago Torres <santiago@nyu.edu> wrote:
> Hi,
>
> I personally like the idea of git-evtags, but I feel that they could be
> made so that push certificates (and being hash-algorithm agnostic)
> should provide the same functionality with less code.
>
> To me, a git evtag is basically a signed tag + a data structure similar
> to a push certificate embedded in it. I wonder if, with the current
> tooling in git, this could be done as a custom command...
In that case, why not migrate Git to a new hash function instead
of adding a very niche fixup?
See Documentation/technical/hash-function-transition.txt
for how to do it.
Personally I'd dislike to include ev-tags as it might send a signal
of "papering over sha1 issues instead of fixing it".
push certificates are somewhat underdocumented, see the
git-push man page, which contains
--[no-]signed, --signed=(true|false|if-asked)
GPG-sign the push request to update refs on the
receiving side, to allow it to be checked by the
hooks and/or be logged. If false or --no-signed, no
signing will be attempted. If true or --signed, the
push will fail if the server does not support signed
pushes. If set to if-asked, sign if and only if the
server supports signed pushes. The push will also
fail if the actual call to gpg --sign fails. See git-
receive-pack(1) for the details on the receiving end.
Going to receive-pack(1), there is an excerpt:
When accepting a signed push (see git-push(1)), the
signed push certificate is stored in a blob and an
environment variable GIT_PUSH_CERT can be consulted for
its object name. See the description of post-receive hook
for an example. In addition, the certificate is verified
using GPG and the result is exported with the following
environment variables:
...
Stefan
next prev parent reply other threads:[~2018-01-08 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 20:12 upstreaming https://github.com/cgwalters/git-evtag ? Colin Walters
2018-01-08 20:34 ` Johannes Schindelin
2018-01-08 20:40 ` Santiago Torres
2018-01-08 20:42 ` Colin Walters
2018-01-08 20:51 ` Santiago Torres
2018-01-08 20:49 ` Stefan Beller [this message]
2018-01-08 20:54 ` Santiago Torres
2018-01-09 2:30 ` Colin Walters
2018-01-09 18:09 ` Santiago Torres
2018-01-09 20:38 ` Jonathan Nieder
2018-01-10 16:38 ` Santiago Torres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kZ8AXezcX1_5WJsUJMHiHCzj2B=Uj8+4K3VF+cC6mTCqA@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=santiago@nyu.edu \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).