From: Stefan Beller <sbeller@google.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Patryk Obara" <patryk.obara@gmail.com>,
"Jeff King" <peff@peff.net>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v2 00/12] object_id part 11 (the_hash_algo)
Date: Thu, 1 Feb 2018 14:06:36 -0800 [thread overview]
Message-ID: <CAGZ79kZ5FT7hD4q+=-AVBUzTaHUjR1sQ3ksmJGHfXzon-az2xA@mail.gmail.com> (raw)
In-Reply-To: <20180201021848.533188-1-sandals@crustytoothpaste.net>
On Wed, Jan 31, 2018 at 6:18 PM, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> This series includes various changes to adopt the use of the_hash_algo
> for abstracting hash algorithms away.
This series looks good to me.
>
> Changes from v1:
> * Fix comments referring to SHA-1.
> * Switch hash function wrappers to take git_hash_ctx *.
> * Use a const int variable for a constant value.
> * Wrap an overly long line.
>
> brian m. carlson (12):
> hash: move SHA-1 macros to hash.h
> hash: create union for hash context allocation
> builtin/index-pack: improve hash function abstraction
> builtin/unpack-objects: switch uses of SHA-1 to the_hash_algo
> sha1_file: switch uses of SHA-1 to the_hash_algo
> fast-import: switch various uses of SHA-1 to the_hash_algo
> pack-check: convert various uses of SHA-1 to abstract forms
> pack-write: switch various SHA-1 values to abstract forms
> read-cache: abstract away uses of SHA-1
> csum-file: rename sha1file to hashfile
> csum-file: abstract uses of SHA-1
> bulk-checkin: abstract SHA-1 usage
>
> builtin/index-pack.c | 108 +++++++++++++++++++++++------------------------
> builtin/pack-objects.c | 52 +++++++++++------------
> builtin/unpack-objects.c | 18 ++++----
> bulk-checkin.c | 28 ++++++------
> cache.h | 25 -----------
> csum-file.c | 46 ++++++++++----------
> csum-file.h | 38 ++++++++---------
> fast-import.c | 70 +++++++++++++++---------------
> hash.h | 40 +++++++++++++++---
> pack-bitmap-write.c | 30 ++++++-------
> pack-check.c | 32 +++++++-------
> pack-write.c | 77 ++++++++++++++++-----------------
> pack.h | 4 +-
> read-cache.c | 58 ++++++++++++-------------
> sha1_file.c | 72 +++++++++++++++----------------
> 15 files changed, 351 insertions(+), 347 deletions(-)
>
next prev parent reply other threads:[~2018-02-01 22:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 2:18 [PATCH v2 00/12] object_id part 11 (the_hash_algo) brian m. carlson
2018-02-01 2:18 ` [PATCH v2 01/12] hash: move SHA-1 macros to hash.h brian m. carlson
2018-02-02 19:39 ` Junio C Hamano
2018-02-01 2:18 ` [PATCH v2 02/12] hash: create union for hash context allocation brian m. carlson
2018-02-01 2:18 ` [PATCH v2 03/12] builtin/index-pack: improve hash function abstraction brian m. carlson
2018-02-01 2:18 ` [PATCH v2 04/12] builtin/unpack-objects: switch uses of SHA-1 to the_hash_algo brian m. carlson
2018-02-01 2:18 ` [PATCH v2 05/12] sha1_file: " brian m. carlson
2018-02-01 2:18 ` [PATCH v2 06/12] fast-import: switch various " brian m. carlson
2018-02-01 2:18 ` [PATCH v2 07/12] pack-check: convert various uses of SHA-1 to abstract forms brian m. carlson
2018-02-01 2:18 ` [PATCH v2 08/12] pack-write: switch various SHA-1 values " brian m. carlson
2018-02-01 2:18 ` [PATCH v2 09/12] read-cache: abstract away uses of SHA-1 brian m. carlson
2018-02-01 2:18 ` [PATCH v2 10/12] csum-file: rename sha1file to hashfile brian m. carlson
2018-02-01 2:18 ` [PATCH v2 11/12] csum-file: abstract uses of SHA-1 brian m. carlson
2018-02-01 2:18 ` [PATCH v2 12/12] bulk-checkin: abstract SHA-1 usage brian m. carlson
2018-02-01 22:06 ` Stefan Beller [this message]
2018-02-02 19:46 ` [PATCH v2 00/12] object_id part 11 (the_hash_algo) Junio C Hamano
2018-02-06 0:34 ` brian m. carlson
2018-02-06 14:52 ` Junio C Hamano
2018-02-08 2:48 ` [PATCH v2] hash: update obsolete reference to SHA1_HEADER brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kZ5FT7hD4q+=-AVBUzTaHUjR1sQ3ksmJGHfXzon-az2xA@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=patryk.obara@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).