mailing list mirror (one of many)
 help / Atom feed
From: Stefan Beller <>
To: Junio C Hamano <>
Cc: Jonathan Tan <>, git <>
Subject: Re: [PATCH] Tests: document test_submodule_{,forced_}switch()
Date: Tue, 7 Nov 2017 09:27:43 -0800
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Nov 6, 2017 at 5:52 PM, Junio C Hamano <> wrote:
> Jonathan Tan <> writes:
>> Factor out the commonalities from test_submodule_switch() and
>> test_submodule_forced_switch() in, and document
>> their usage.
>> This also makes explicit (through the KNOWN_FAILURE_FORCED_SWITCH_TESTS
>> variable) the fact that, currently, all functionality tested using
>> test_submodule_forced_switch() do not correctly handle the situation in
>> which a submodule is replaced with an ordinary directory.
>> Signed-off-by: Jonathan Tan <>
>> ---
>> I find tests that use difficult to understand
>> due to the lack of clarity of what test_submodule_switch() and others do
>> with their argument - I hope this will make things easier for future
>> readers.
>> ---
>>  t/ | 250 +++++++++-------------------------------------
>>  1 file changed, 46 insertions(+), 204 deletions(-)
> I suspect that the benefit of this is a lot larger than "document" a
> test helper function or two ;-)  "document & clean-up", perhaps?

It is.

> I didn't compare the before-and-after with fine toothed comb, but
> a cursory look didn't find anything glaringly questionable other
> than the above.

I have reviewed the patch and thinks it withstands the test of a fine comb.

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 23:50 Jonathan Tan
2017-11-07  1:52 ` Junio C Hamano
2017-11-07 17:27   ` Stefan Beller [this message]
2017-11-07 18:45   ` [PATCH v2] Tests: clean up and document submodule helpers Jonathan Tan

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox