From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <l.s.r@web.de>,
jeremy@feusi.co, git <git@vger.kernel.org>,
"Prathamesh Chavan" <pc44800@gmail.com>
Subject: Re: Null pointer dereference in git-submodule
Date: Wed, 28 Mar 2018 10:03:09 -0700 [thread overview]
Message-ID: <CAGZ79kYveU=TK-zvxNimSYcQqhOf4OFgynuNDu08bvbDtwfEEA@mail.gmail.com> (raw)
In-Reply-To: <xmqqlgec87ns.fsf@gitster-ct.c.googlers.com>
On Wed, Mar 28, 2018 at 9:52 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>>> Subject: [PATCH v2] submodule: check for NULL return of
>> get_submodule_ref_store()
>>
>> Maybe more imperative, telling what we actually want
>> to achieve instead of what we do?
>>
>> submodule: report deleted submodules as not initialized
>>
>>> If we can't find a ref store for a submodule then assume it the latter
>>> is not initialized (or was removed). Print a status line accordingly
>>> instead of causing a segmentation fault by passing NULL as the first
>>> parameter of refs_head_ref().
>>
>> Thanks for the message here. Looks good!
>> ...
>> Which would be added in t/t7400-submodule-basic.sh
>>
>> Thanks for coming up with a sensible patch!
>
> I take the above to mean that you as a contributor active in this
> area like the general idea in the patch but not volunteering to take
> this topic over
Rereading the discussion, I overlooked the author of the second patch
to be Rene (for some reason I thought someone else would have
written that patch. Sorry about that!)
> and instead trust René to tie the loose ends with a
> reroll, taking hints from your suggestions?
As Rene likes. I can reroll that patch with a test, too.
I'd pick it up after rerolling the series from yesterday
(moving nested submodules).
> I just wanted to make sure that we won't be confused whose turn it
> is next (e.g. me waiting for update to t7400 from you or René doing
> the same).
Thanks,
Stefan
next prev parent reply other threads:[~2018-03-28 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 9:50 Null pointer dereference in git-submodule Jeremy Feusi
2018-03-25 10:57 ` René Scharfe
2018-03-27 23:50 ` Stefan Beller
2018-03-28 16:52 ` Junio C Hamano
2018-03-28 17:03 ` Stefan Beller [this message]
2018-03-28 18:38 ` [PATCH] submodule: check for NULL return of get_submodule_ref_store() Stefan Beller
2018-03-28 18:57 ` Eric Sunshine
2018-03-28 20:08 ` Stefan Beller
2018-03-28 20:21 ` Eric Sunshine
2018-03-28 20:54 ` Stefan Beller
2018-03-28 21:14 ` René Scharfe
2018-03-28 21:37 ` Stefan Beller
2018-03-28 22:24 ` René Scharfe
2018-03-28 22:35 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2018-03-24 17:42 Null pointer dereference in git-submodule Jeremy Feusi
2018-03-24 20:42 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kYveU=TK-zvxNimSYcQqhOf4OFgynuNDu08bvbDtwfEEA@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeremy@feusi.co \
--cc=l.s.r@web.de \
--cc=pc44800@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).