From: Stefan Beller <sbeller@google.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/4] git-compat-util.h: xsize_t() - avoid -Wsign-compare warnings
Date: Thu, 21 Sep 2017 11:57:26 -0700 [thread overview]
Message-ID: <CAGZ79kYuGpO5Ji9vwqwy_2=ea2Vd9CG2ethzyhXUc709KQSSaQ@mail.gmail.com> (raw)
In-Reply-To: <75416139-74c5-8a60-22e8-79c53dd062c1@web.de>
On Thu, Sep 21, 2017 at 11:49 AM, Torsten Bögershausen <tboegi@web.de> wrote:
> On 2017-09-21 18:46, Ramsay Jones wrote:
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>> git-compat-util.h | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/git-compat-util.h b/git-compat-util.h
>> index 9bc15b036..cedad4d58 100644
>> --- a/git-compat-util.h
>> +++ b/git-compat-util.h
>> @@ -898,9 +898,11 @@ static inline char *xstrdup_or_null(const char *str)
>>
>> static inline size_t xsize_t(off_t len)
>> {
>> - if (len > (size_t) len)
>> + size_t size = (size_t) len;
>> +
>> + if (len != (off_t) size)
>> die("Cannot handle files this big");
>> - return (size_t)len;
>> + return size;
>
> Hm, can someone help me out ?
> Why is the cast not needed ?
Because 'size' is already size_t,
(cast was done in first line of the function:
size_t size = (size_t) len;
), previously we cast len multiple times,
now we cast it once and use size thereafter.
>
>> }
>>
>> __attribute__((format (printf, 3, 4)))
>>
>
next prev parent reply other threads:[~2017-09-21 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 16:46 [PATCH 1/4] git-compat-util.h: xsize_t() - avoid -Wsign-compare warnings Ramsay Jones
2017-09-21 18:49 ` Torsten Bögershausen
2017-09-21 18:57 ` Stefan Beller [this message]
2017-09-21 19:02 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kYuGpO5Ji9vwqwy_2=ea2Vd9CG2ethzyhXUc709KQSSaQ@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).