From: Stefan Beller <sbeller@google.com>
To: Andrey Rybak <rybak.a.v@gmail.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Brandon Williams <bmwill@google.com>
Subject: Re: [PATCH 9/9] diff.c: add white space mode to move detection that allows indent changes
Date: Wed, 18 Jul 2018 11:27:53 -0700 [thread overview]
Message-ID: <CAGZ79kYnkfrrTRVOZx4iZfRK=s4YcMmPtk8zPDfvFwXeqRYo3Q@mail.gmail.com> (raw)
In-Reply-To: <1f7b84aa-5ddb-431a-baa9-16ebb5020670@gmail.com>
On Wed, Jul 18, 2018 at 11:25 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
>
> On 2018-07-17 01:05, Stefan Beller wrote:
> >
> > This patch brings some challenges, related to the detection of blocks.
> > We need a white net the catch the possible moved lines, but then need to
>
> The s/white/wide/ was already suggested by Brandon Williams in previous
> iteration, but it seems this also needs s/the catch/to catch/
>
Both fixed locally, thanks!
I'll resend this series later.
prev parent reply other threads:[~2018-07-18 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 23:05 [PATCHv5 0/9] Reroll of sb/diff-color-move-more Stefan Beller
2018-07-16 23:05 ` [PATCH 1/9] xdiff/xdiff.h: remove unused flags Stefan Beller
2018-07-16 23:05 ` [PATCH 2/9] xdiff/xdiffi.c: remove unneeded function declarations Stefan Beller
2018-07-16 23:05 ` [PATCH 3/9] t4015: avoid git as a pipe input Stefan Beller
2018-07-16 23:05 ` [PATCH 4/9] diff.c: do not pass diff options as keydata to hashmap Stefan Beller
2018-07-16 23:05 ` [PATCH 5/9] diff.c: adjust hash function signature to match hashmap expectation Stefan Beller
2018-07-16 23:05 ` [PATCH 6/9] diff.c: add a blocks mode for moved code detection Stefan Beller
2018-07-16 23:05 ` [PATCH 7/9] diff.c: decouple white space treatment from move detection algorithm Stefan Beller
2018-07-16 23:05 ` [PATCH 8/9] diff.c: factor advance_or_nullify out of mark_color_as_moved Stefan Beller
2018-07-16 23:05 ` [PATCH 9/9] diff.c: add white space mode to move detection that allows indent changes Stefan Beller
2018-07-18 18:25 ` Andrei Rybak
2018-07-18 18:27 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kYnkfrrTRVOZx4iZfRK=s4YcMmPtk8zPDfvFwXeqRYo3Q@mail.gmail.com' \
--to=sbeller@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).