From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Beller Subject: Re: [PATCH 1/4] recursive submodules: test for relative paths Date: Thu, 31 Mar 2016 09:47:22 -0700 Message-ID: References: <1459383457-6848-1-git-send-email-sbeller@google.com> <1459383457-6848-2-git-send-email-sbeller@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "git@vger.kernel.org" , Norio Nomura To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Mar 31 18:47:30 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1alfkm-0001Ln-82 for gcvg-git-2@plane.gmane.org; Thu, 31 Mar 2016 18:47:28 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756946AbcCaQrY (ORCPT ); Thu, 31 Mar 2016 12:47:24 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:35617 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbcCaQrX (ORCPT ); Thu, 31 Mar 2016 12:47:23 -0400 Received: by mail-ig0-f176.google.com with SMTP id cl4so130570046igb.0 for ; Thu, 31 Mar 2016 09:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=668tMPWdk0oSVV63Av4L3umYpfIo2SM1zkLYf35pPU4=; b=MGhKzH3MQafKkIgcavm7SqWOB+NxxUKaWl5Cld5961d8ugRvwgK7IuTs+9nBrR3LET X/p6OQGk8/nAaQ7VjHy4WWVrZibNCuSFF6foDUyFTlHRhNiWaNQrPw6n9EoWozNCvLlC iWNsQpZLYYq5PbKff1UB4YL4pre/KcprnyDb++tvqthdZZGG2smmoc7DKeYbc1fJ3yaQ cqVkL48jxBGyUGW/a2u0QddWovVL5OuMSyhv2jXFOR7wRjjKnb1buycaC/TKxGZFs85J YyHH5wEF5EquxB78dBuod9g00N9VEW4DRRS9nh1ny4bUkYrlcUoeITaRkxi84vL8ZRou DLug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=668tMPWdk0oSVV63Av4L3umYpfIo2SM1zkLYf35pPU4=; b=MwZTakwrgm1W1jrlpbPPLgJtMvTtjGIsZi/koLRblTAVUvSmMTf4kL3kNxYwcWwVEU 85l7ncVWTERW4KsiKS76EAQTbS5SLby5VEy1NqcbuO+5gWkFwSp6FqQiVWXySVvHbR1M cHORI/gFZs+eJoVG7uD3kqoUF2EIxebSr8H9hJjyVc2dvPQl2AIL+SlU5lFnLM7NXXX9 gyv5tIRBh5bNSfz+ktJVswQ+EgcudW6eli9pf7zzPv5iLTYhpnaDpiSW300PWjex7K9u whnzAHuBBdzFoXNb3AX3slkA0LudecyhLsP2OvAcQ/7zAQM7B9Cz6z8x7KpyVRuwQBUe bSjA== X-Gm-Message-State: AD7BkJLnPCvUcInV5ZwErdbeK5RWa3Aj/hKDNqR36t3Ssa+UIhyPhS3yaUftfZ63InTnOpU5siMwrdW7JDy4ymxk X-Received: by 10.50.57.50 with SMTP id f18mr613281igq.93.1459442842621; Thu, 31 Mar 2016 09:47:22 -0700 (PDT) Received: by 10.107.17.27 with HTTP; Thu, 31 Mar 2016 09:47:22 -0700 (PDT) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Mar 31, 2016 at 9:33 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> This was reported as a regression at $gmane/290280. The root cause for >> that bug is in using recursive submodules as their relative path handling >> seems to be broken in ee8838d (2015-09-08, submodule: rewrite >> `module_clone` shell function in C). > > I've reworded the above like so while queuing. > > "git submodule update --init --recursive" uses full path to refer to > the true location of the repository in the "gitdir:" pointer for > nested submodules; the command used to use relative paths. > > This was reported by Norio Nomura in $gmane/290280. > > The root cause for that bug is in using recursive submodules as > their relative path handling was broken in ee8838d (2015-09-08, > submodule: rewrite `module_clone` shell function in C). > > Thanks. > Thanks! I'll pickup the reworded version and resend the series as there seems to be discussion on the other patches which requires some work by me.