git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* [PATCH] diff-options.txt: fix minor typos, font inconsistencies, in docs
@ 2018-06-11 13:56 Robert P. J. Day
  2018-06-11 21:31 ` Stefan Beller
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2018-06-11 13:56 UTC (permalink / raw)
  To: Git Mailing list

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
index f466600972..30aad8396d 100644
--- a/Documentation/diff-options.txt
+++ b/Documentation/diff-options.txt
@@ -64,7 +64,7 @@ ifndef::git-format-patch[]
 endif::git-format-patch[]

 --indent-heuristic::
-	Enable the heuristic that shift diff hunk boundaries to make patches
+	Enable the heuristic that shifts diff hunk boundaries to make patches
 	easier to read. This is the default.

 --no-indent-heuristic::
@@ -106,7 +106,7 @@ diff" algorithm internally.
 	low-occurrence common elements".
 --
 +
-For instance, if you configured diff.algorithm variable to a
+For instance, if you configured the `diff.algorithm` variable to a
 non-default value and want to use the default one, then you
 have to use `--diff-algorithm=default` option.

@@ -350,7 +350,7 @@ ifndef::git-format-patch[]
 	Warn if changes introduce conflict markers or whitespace errors.
 	What are considered whitespace errors is controlled by `core.whitespace`
 	configuration.  By default, trailing whitespaces (including
-	lines that solely consist of whitespaces) and a space character
+	lines that consist solely of whitespaces) and a space character
 	that is immediately followed by a tab character inside the
 	initial indent of the line are considered whitespace errors.
 	Exits with non-zero status if problems are found. Not compatible
@@ -364,7 +364,7 @@ ifndef::git-format-patch[]
 	this option is not given, and the configuration variable
 	`diff.wsErrorHighlight` is not set, only whitespace errors in
 	`new` lines are highlighted. The whitespace errors are colored
-	whith `color.diff.whitespace`.
+	with `color.diff.whitespace`.

 endif::git-format-patch[]

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] diff-options.txt: fix minor typos, font inconsistencies, in docs
  2018-06-11 13:56 [PATCH] diff-options.txt: fix minor typos, font inconsistencies, in docs Robert P. J. Day
@ 2018-06-11 21:31 ` Stefan Beller
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Beller @ 2018-06-11 21:31 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: git

On Mon, Jun 11, 2018 at 6:58 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

The code is
Reviewed-by: Stefan Beller <sbeller@google.com>

Is this patch missing three dashes between commit message and the patch itself?
How did you send this patch?

>
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index f466600972..30aad8396d 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -64,7 +64,7 @@ ifndef::git-format-patch[]
>  endif::git-format-patch[]
>
>  --indent-heuristic::
> -       Enable the heuristic that shift diff hunk boundaries to make patches
> +       Enable the heuristic that shifts diff hunk boundaries to make patches
>         easier to read. This is the default.
>
>  --no-indent-heuristic::
> @@ -106,7 +106,7 @@ diff" algorithm internally.
>         low-occurrence common elements".
>  --
>  +
> -For instance, if you configured diff.algorithm variable to a
> +For instance, if you configured the `diff.algorithm` variable to a
>  non-default value and want to use the default one, then you
>  have to use `--diff-algorithm=default` option.
>
> @@ -350,7 +350,7 @@ ifndef::git-format-patch[]
>         Warn if changes introduce conflict markers or whitespace errors.
>         What are considered whitespace errors is controlled by `core.whitespace`
>         configuration.  By default, trailing whitespaces (including
> -       lines that solely consist of whitespaces) and a space character
> +       lines that consist solely of whitespaces) and a space character
>         that is immediately followed by a tab character inside the
>         initial indent of the line are considered whitespace errors.
>         Exits with non-zero status if problems are found. Not compatible
> @@ -364,7 +364,7 @@ ifndef::git-format-patch[]
>         this option is not given, and the configuration variable
>         `diff.wsErrorHighlight` is not set, only whitespace errors in
>         `new` lines are highlighted. The whitespace errors are colored
> -       whith `color.diff.whitespace`.
> +       with `color.diff.whitespace`.
>
>  endif::git-format-patch[]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-11 13:56 [PATCH] diff-options.txt: fix minor typos, font inconsistencies, in docs Robert P. J. Day
2018-06-11 21:31 ` Stefan Beller

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox