From: Stefan Beller <sbeller@google.com>
To: draftcode@gmail.com
Cc: git <git@vger.kernel.org>, Masaya Suzuki <masayasuzuki@google.com>
Subject: Re: [PATCH] doc: fix want-capability separator
Date: Mon, 30 Jul 2018 11:26:21 -0700 [thread overview]
Message-ID: <CAGZ79kYOqP-8t1r_-NVLA025UP+_Zi5SXHWfc7HxRo9gemWDpQ@mail.gmail.com> (raw)
In-Reply-To: <20180728211630.29573-1-masayasuzuki@google.com>
On Sat, Jul 28, 2018 at 2:16 PM Masaya Suzuki <draftcode@gmail.com> wrote:
> Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
The email addresses mismatch?
> Unlike ref advertisement, client capabilities and the first want are
> separated by SP, not NUL, in the implementation. Fix the documentation
> to align with the implementation.
Makes sense! Thanks for the fix!
> pack-protocol.txt is already fixed.
which has
capability-list = capability *(SP capability)
since b31222cfb7f (Update packfile transfer protocol
documentation, 2009-11-03), which is the first to mention
the capability line, so I'd claim it was always correct?
>
> ---
> Documentation/technical/http-protocol.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt
> index 64f49d0bb..9c5b6f0fa 100644
> --- a/Documentation/technical/http-protocol.txt
> +++ b/Documentation/technical/http-protocol.txt
> @@ -338,11 +338,11 @@ server advertises capability `allow-tip-sha1-in-want` or
> request_end
> request_end = "0000" / "done"
>
> - want_list = PKT-LINE(want NUL cap_list LF)
> + want_list = PKT-LINE(want SP cap_list LF)
> *(want_pkt)
> want_pkt = PKT-LINE(want LF)
> want = "want" SP id
> - cap_list = *(SP capability) SP
> + cap_list = capability *(SP capability)
>
> have_list = *PKT-LINE("have" SP id LF)
Just after these context lines we have
TODO: Document this further.
which is a good hint that the existing documentation
can benefit from patches like these.
Thanks,
Stefan
prev parent reply other threads:[~2018-07-30 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 21:16 [PATCH] doc: fix want-capability separator Masaya Suzuki
2018-07-30 18:26 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kYOqP-8t1r_-NVLA025UP+_Zi5SXHWfc7HxRo9gemWDpQ@mail.gmail.com \
--to=sbeller@google.com \
--cc=draftcode@gmail.com \
--cc=git@vger.kernel.org \
--cc=masayasuzuki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).