From: Stefan Beller <sbeller@google.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j6t@kdbg.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] git: add --no-optional-locks option
Date: Fri, 22 Sep 2017 14:41:06 -0700 [thread overview]
Message-ID: <CAGZ79kYJH-4qb5hiT1C_aCFXLcdiJs5h+Z7Goz4trp52C5s3Lw@mail.gmail.com> (raw)
In-Reply-To: <20170922212525.kxldygbjrmjqu7ci@sigill.intra.peff.net>
On Fri, Sep 22, 2017 at 2:25 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Sep 22, 2017 at 01:09:32PM -0700, Stefan Beller wrote:
>
>> On Thu, Sep 21, 2017 at 9:25 PM, Jeff King <peff@peff.net> wrote:
>>
>> >
>> > But imagine that "git status" learns to recurse into submodules and run
>> > "git status" inside them. Surely we would want the submodule repos to
>> > also avoid taking any unnecessary locks?
>>
>> You can teach Git to recurse into submodules already at home,
>> just 'git config status.submoduleSummary none'. ;)
>>
>> It occurs to me that the config name is badly choosen, as it stores
>> an argument for git status --ignore-submodules[=mode]
>
> Ah, thanks. I _thought_ we could already do that but when I went looking
> for the standard --recursive option I couldn't find it.
Thanks for checking for submodules there.
I personally prefer --recurse-submodules despite the longer name,
because a plain recursive option can mean anything in a sufficiently
complex program such as Git (recurse into the tree (c.f. ls-tree), or
for the algorithm used (c.f. merge, diff) or yet another dimension
I did not think of).
> So yes, I would think we would want this option to apply recursively in
> that case, even when we cross repository boundaries.
Regarding the actual patch which is heavily aimed at coping with IDEs
despite the command line being used, I wonder how many IDEs pass
--ignore-submodules and recurse themselves (if needed). Reason for
my suspicion is [1] which does pay attention to submodules:
> Our application calls status including the following flags:
> --porcelain=v2 --ignored --untracked-files=all --ignore-submodules=none
[1] https://public-inbox.org/git/2bbb1d0f-ae06-1878-d185-112bd51f75c9@gmail.com/
There might be another option to cope with the situation:
4. Teach all commands to spinlock / busywait shortly for important
locks instead of giving up. In that case git-status rewriting
the index ought to be fine?
Thanks,
Stefan
next prev parent reply other threads:[~2017-09-22 21:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 4:32 [PATCH] git: add --no-optional-locks option Jeff King
2017-09-21 4:55 ` Junio C Hamano
2017-09-21 5:08 ` Jeff King
2017-09-21 5:29 ` Junio C Hamano
2017-09-21 18:25 ` Johannes Sixt
2017-09-22 4:25 ` Jeff King
2017-09-22 11:22 ` Jeff Hostetler
2017-09-22 15:04 ` Jeff King
2017-09-22 20:09 ` Stefan Beller
2017-09-22 21:25 ` Jeff King
2017-09-22 21:41 ` Stefan Beller [this message]
2017-09-23 3:34 ` Jeff King
2017-09-25 18:51 ` Stefan Beller
2017-09-27 6:44 ` Jeff King
2017-09-22 6:42 ` Daniel Santos
2017-09-22 16:04 ` Jeff King
2017-09-24 11:31 ` Kaartic Sivaraam
2017-09-25 16:17 ` Johannes Schindelin
2017-09-26 14:44 ` Jeff Hostetler
2017-09-25 16:10 ` Johannes Schindelin
2017-09-25 17:00 ` Jeff King
[not found] ` <79ed4c34-1727-7c1e-868a-1206902638ad@gmail.com>
2017-09-27 6:40 ` Jeff King
2017-09-27 13:50 ` Kaartic Sivaraam
2017-09-27 16:28 ` Jeff King
2017-09-27 6:54 ` [PATCH v2] " Jeff King
2017-09-28 16:15 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kYJH-4qb5hiT1C_aCFXLcdiJs5h+Z7Goz4trp52C5s3Lw@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).