From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 50841209FD for ; Tue, 6 Jun 2017 18:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751465AbdFFSsg (ORCPT ); Tue, 6 Jun 2017 14:48:36 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34106 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbdFFSsL (ORCPT ); Tue, 6 Jun 2017 14:48:11 -0400 Received: by mail-pf0-f170.google.com with SMTP id 9so100726678pfj.1 for ; Tue, 06 Jun 2017 11:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=i0gKJI+dMnWASCSVBPLmHVEw5YOkAr32zQDrkGIxqY0=; b=YyZMyQ3cMtTVtDhURi1BtFtZTa43g6WV1ak7q1lnocDqjICxfHZ2so2hKELdczNR84 ROGSK6TAxEP5RN4F+Yi1ZL07CpRUfi5kfD5QBIaAXKq03CLvtdanEf/5cZBgYF9JzuHe jQrCJU435QPmeuIYhlXzF44UiDSGdV7XBqsWKt1xtN3s10h4wOQHBPiWuxO9cuoSkQhn x6ojTXJ6cWETDam3LL2GWU8LnhgNJ1iYFP05RsebJF0XF2wwdLDAsVHoAvdfDUI2dsP7 /Nik29qUys2ZmlKb2BEdcvMIp4rZ71yxvn+8U7COo93gCldbOhjHw92KILEkho71jKoB tFmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=i0gKJI+dMnWASCSVBPLmHVEw5YOkAr32zQDrkGIxqY0=; b=PpClzkX8GAMQ/hEIxkvlw4jcWkt4hS1STZ89qE+/NeX41pyMjmjx93vBq4qjeG4aVi XdL7JhnIA4Vvu+b8W00ctcKfNkcN4G7KzeVwf1Qk+l/mriKvNAkM9MvvAcXJpb43jS7y QTD+EZavsn7jkJH2kD1jN1te87kZDBVabsgqYAzMtmHIG0kiNbHzbkUrHLfhFaPhl4Tt koOgqGiojf11ibIs0vmEcgz+LkeXo5KjvhMIXY/ZSbnk7lyeZfFIBaE5QimwzSHvedzX jeb+0u6i4VqaPjgZdap2ALhmB2SPpShoLLPjtK1p1sl/Cijqg++05jILAlmuvK7wsIS/ tHnA== X-Gm-Message-State: AODbwcCHXYcnWXibECvHNhOO77U9ecmaFIEJPcwElQNcRv7StkYitF0s 2vJ/vr26FgIrrIgED2KYbnH8wJqsLY5m X-Received: by 10.98.34.8 with SMTP id i8mr14564317pfi.194.1496774891132; Tue, 06 Jun 2017 11:48:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.218.134 with HTTP; Tue, 6 Jun 2017 11:48:10 -0700 (PDT) In-Reply-To: <20170606151231.25172-3-avarab@gmail.com> References: <20170606124323.GD25777@dinwoodie.org> <20170606151231.25172-1-avarab@gmail.com> <20170606151231.25172-3-avarab@gmail.com> From: Stefan Beller Date: Tue, 6 Jun 2017 11:48:10 -0700 Message-ID: Subject: Re: [PATCH 2/3] sha1dc: optionally use sha1collisiondetection as a submodule To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: "git@vger.kernel.org" , Junio C Hamano , Adam Dinwoodie , Ramsay Jones , "Liam R . Howlett" , Michael Kebe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jun 6, 2017 at 8:12 AM, =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason wrote: > Add an option to use the sha1collisiondetection library from the > submodule in sha1collisiondetection/ instead of in the copy in the > sha1dc/ directory. > > This allows us to try out the submodule in sha1collisiondetection > without breaking the build for anyone who's not expecting them as we > work out any kinks. > > Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason Other projects using submodules sometimes have a .gitattributes entry to have .gitmodules not exported via git-archive. Do we want a similar thing? Speaking of attributes, I wonder if we want to specify the .gitmodules file to be text with unixy file endings: Having an entry .gitattributes eol=3Dcrlf to simulate a Windows environment doesn't harm submodule operation, which is good. I'll check if we have a test for that.