From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Subject: Re: [PATCH/FINAL] Documentation/git-submodule: cleanup
Date: Thu, 22 Jun 2017 12:13:42 -0700 [thread overview]
Message-ID: <CAGZ79kYAJR7WXn9p1tGXTWTw9V4kpBX9g_W2_dy0AE9OLFPcvw@mail.gmail.com> (raw)
In-Reply-To: <xmqqr2ybkfj7.fsf@gitster.mtv.corp.google.com>
On Thu, Jun 22, 2017 at 12:07 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
>
>> The "add" section for 'git-submodule' is redundant in
>> its description and the short synopsis line. Fix it.
>>
>> Remove the redundant mentioning of the 'repository' argument
>> being mandatory.
>>
>> The text is hard to read because of back-references, so remove
>> those.
>>
>> Replace the word "humanish" by "canonical" as that conveys better
>> what we do to guess the path.
>>
>> While at it, quote all occurrences of '.gitmodules' as that is an
>> important file in the submodule context, also link to it on its
>> first mention.
>>
>> Helped-by: Stefan Beller <sbeller@google.com>
>> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
>> ---
>
> Stefan, do you want to add a Reviewed-by: to this one? I've scanned
> it over and overall it looked OK (iow I didn't find anything worth
> complaining about).
I found it a pleasant read, thanks.
As all occurrences of '.gitmodules' are touched, I suspect we will run into
a conflict with sb/submodule-doc, such that I will rebase on top of this.
Thanks,
Stefan
next prev parent reply other threads:[~2017-06-22 19:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 3:05 [PATCH/RFC] Cleanup Documentation Kaartic Sivaraam
2017-06-19 5:24 ` Junio C Hamano
2017-06-19 5:50 ` Stefan Beller
2017-06-19 17:33 ` Kaartic Sivaraam
2017-06-19 17:54 ` Stefan Beller
2017-06-20 3:12 ` Kaartic Sivaraam
2017-06-20 16:57 ` Stefan Beller
2017-06-20 17:05 ` Stefan Beller
2017-06-21 3:02 ` [PATCH/FINALRFC] Documentation/git-submodule: cleanup Kaartic Sivaraam
2017-06-21 16:11 ` Junio C Hamano
2017-06-21 17:41 ` Kaartic Sivaraam
2017-06-22 2:51 ` [PATCH/FINAL] " Kaartic Sivaraam
2017-06-22 19:07 ` Junio C Hamano
2017-06-22 19:13 ` Stefan Beller [this message]
2017-06-20 18:27 ` [PATCH/RFC] Cleanup Documentation Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kYAJR7WXn9p1tGXTWTw9V4kpBX9g_W2_dy0AE9OLFPcvw@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaarticsivaraam91196@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).