git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore
@ 2017-03-20 15:50 Sebastian Schuberth
  2017-03-20 17:43 ` Stefan Beller
  0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Schuberth @ 2017-03-20 15:50 UTC (permalink / raw)
  To: git

Hi,

I'm using

$ git --version
git version 2.12.0.windows.1

With this version, when I do a "reword" during an inteactive rebase 
session, the commit-msg hook doe snot seem to be triggered anymore. This 
was particularly useful to let Gerrit's commit-msg hook add missing 
ChangeId footers.

I can work-aorund the issue by doing an "edit" and "commit --amend".

Is anyone else seeing this?

Regards,
Sebastian


^ permalink raw reply	[flat|threaded] 3+ messages in thread

* Re: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore
  2017-03-20 15:50 Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore Sebastian Schuberth
@ 2017-03-20 17:43 ` Stefan Beller
  2017-03-21  9:14   ` Sebastian Schuberth
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Beller @ 2017-03-20 17:43 UTC (permalink / raw)
  To: Sebastian Schuberth, Johannes Schindelin; +Cc: git

On Mon, Mar 20, 2017 at 8:50 AM, Sebastian Schuberth
<sschuberth@gmail.com> wrote:
> Hi,
>
> I'm using
>
> $ git --version
> git version 2.12.0.windows.1
>
> With this version, when I do a "reword" during an inteactive rebase session,
> the commit-msg hook doe snot seem to be triggered anymore. This was
> particularly useful to let Gerrit's commit-msg hook add missing ChangeId
> footers.
>
> I can work-aorund the issue by doing an "edit" and "commit --amend".
>
> Is anyone else seeing this?

In 2.12 RelNotes:

 * "git rebase -i" starts using the recently updated "sequencer" code.

+cc Johannes

^ permalink raw reply	[flat|threaded] 3+ messages in thread

* Re: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore
  2017-03-20 17:43 ` Stefan Beller
@ 2017-03-21  9:14   ` Sebastian Schuberth
  0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Schuberth @ 2017-03-21  9:14 UTC (permalink / raw)
  To: git; +Cc: git

On 3/20/2017 18:43, Stefan Beller wrote:

>> With this version, when I do a "reword" during an inteactive rebase session,
>> the commit-msg hook doe snot seem to be triggered anymore. This was
>> particularly useful to let Gerrit's commit-msg hook add missing ChangeId
>> footers.
>>
>> I can work-aorund the issue by doing an "edit" and "commit --amend".
>>
>> Is anyone else seeing this?
>
> In 2.12 RelNotes:
>
>  * "git rebase -i" starts using the recently updated "sequencer" code.

Thanks, that looks like a possible culprit. I can *not* reproduce the 
issue on Linux with "git version 2.12.1-382-gc0f9c70", thought. So 
either it's Windows-specific, or it has been fixed in 2.12.1 already.

Regards,
Sebastian




^ permalink raw reply	[flat|threaded] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-20 15:50 Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore Sebastian Schuberth
2017-03-20 17:43 ` Stefan Beller
2017-03-21  9:14   ` Sebastian Schuberth

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox