git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
To: Noman <necrospre@gmail.com>
Cc: git@vger.kernel.org, jltobler@gmail.com,
	 karthik nayak <karthik.188@gmail.com>,
	Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Subject: Re: [GSoC][PATCH] doc: fix doubled words in gitdiffcore documentation
Date: Sat, 28 Mar 2026 11:53:02 +0530	[thread overview]
Message-ID: <CAGWgyh9a7sfEXcd5B7tv6DzZ6Ma_=+zOK9w1vkwq81P4MRM9LA@mail.gmail.com> (raw)

Hello Noman,

> Hello Git community,
> I am Naorem Ngathoiba Singh, a GSoC 2026 applicant interested in the
> 'Improve the new git repo command' project. As my microproject, I have
> identified and fixed some doubled words in the documentation. Below is
> my patch.

Thank you for your patch and your interest in GSoC 2026

> -and the contents of the deleted file fileX is similar enough to
> +and the contents of the deleted file X is similar enough to

> -these filepairs, that talk about a modified file fileY and a newly
> +these filepairs, that talk about a modified file Y and a newly

I believe these changes are incorrect because the current wording
appears to be intentional.
In the context of gitdiffcore.adoc, "fileX" and "fileY" are used as
specific variable identifiers for the files being discussed in the
diff examples.

In this instance, "file" is the noun and "fileX" is the name of that
file in the example (similar to how one says "the variable varX").
Changing "fileX" to "X" actually changes the identifier, which might
make the documentation harder to follow for a reader trying to track
which file is which.

Since "fileX" and "fileY" are used consistently as placeholders in
this document, I would suggest leaving them as they are.

Regards,
Siddharth Shrimali
r.siddharth.shrimali@gmail.com


             reply	other threads:[~2026-03-28  6:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28  6:23 Siddharth Shrimali [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-28  5:41 [GSoC][PATCH] doc: fix doubled words in gitdiffcore documentation Noman
2026-03-28 17:29 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWgyh9a7sfEXcd5B7tv6DzZ6Ma_=+zOK9w1vkwq81P4MRM9LA@mail.gmail.com' \
    --to=r.siddharth.shrimali@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=necrospre@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).