From: Bret Barkelew <bret@corthon.com> To: Johannes Schindelin <Johannes.Schindelin@gmx.de> Cc: Bryan Turner <bturner@atlassian.com>, git@vger.kernel.org Subject: Re: git version 2.20.1.windows.1 throws file name too long in gitk Date: Thu, 10 Jan 2019 10:55:35 -0800 Message-ID: <CAGTkKagTCw-EcMo3M1P3XVtjbTcm4HPjCWGZ1sM_NnJwH7v_hg@mail.gmail.com> (raw) In-Reply-To: <nycvar.QRO.7.76.6.1901101616100.41@tvgsbejvaqbjf.bet> On Thu, Jan 10, 2019 at 7:20 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > > Hi Bret, > > in that case, please try to find a way to trace the commands in a Tcl/Tk > program (which gitk is) and see which command triggers the error. Er... that's a little out of my depth. I'll see if I can find time to learn. Meanwhile, is there any way to request better instrumentation for the error dialog so this data could have been collected for me? > > Ciao, > Johannes > > > On Wed, 9 Jan 2019, Bret Barkelew wrote: > > > Will try to reply in-line, when appropriate. > > The latest snapshot (git version 2.20.1.windows.1.5.g6b286585b1) still > > has the issue. > > > > - Bret > > > > > > On Wed, Jan 9, 2019 at 10:39 AM Johannes Schindelin > > <Johannes.Schindelin@gmx.de> wrote: > > > > > > Hi Bret, > > > > > > > > > On Thu, 3 Jan 2019, Bret Barkelew wrote: > > > > > > > They are the exact same path (with a different drive letter). > > > > > > [it's a bit hard to follow the thread if you top-post a reply to an > > > inline-replied answer, maybe imitate the style of other mails in the > > > future.] > > > > > > > Another thing I've been able to confirm is I uninstalled git 2.20.1 > > > > and installed 2.19.0 on the failing system, and the older version of > > > > Git works. > > > > I've also tried a suggested fix I saw elsewhere to enable long path > > > > names in the Windows registry, which did not resolve the issue with > > > > git 2.20.1. > > > > > > > > Happy to collect any additional data. > > > > > > Please try the latest snapshot at > > > https://wingit.blob.core.windows.net/files/index.html (I *think* the bug > > > might be fixed via > > > https://github.com/git-for-windows/MINGW-packages/pull/32). > > > > > > Ciao, > > > Johannes > > > > > > > - Bret > > > > > > > > On Thu, Jan 3, 2019 at 7:10 PM Bryan Turner <bturner@atlassian.com> wrote: > > > > > > > > > > On Thu, Jan 3, 2019 at 6:21 PM Bret Barkelew <bret@corthon.com> wrote: > > > > >> > > > > >> When I open gitk in a particular repository under this version of Git > > > > >> for Windows, I now get a dialog box that says "Error: couldn't execute > > > > >> "git": file name too long". I've noticed that the most pronounced > > > > >> effect is that I cannot see the file diffs (or sometimes the file name > > > > >> list) for any of the commits. I don't know the exact repro, but I've > > > > >> narrowed down the following things: > > > > >> > > > > >> - This does not happen with the same repo if I use a system that has > > > > >> git 2.19.0.windows.1 on another machine. > > > > >> - This does not happen on my current machine in a freshly cloned repo. > > > > > > > > > > > > > > > How “deep” are the paths to the different clones on the different systems? Are all of the clones at exactly the same path on disk? > > > > > > > > > > Git on Windows is (by defaulted) limited by MAX_PATH, which is 260 characters. That length is calculated including the path to the repository itself and then to the file inside the repository. That means, for example, a given repository cloned to C:\repo may not have issues, but the same repository cloned to C:\Users\Bryan\Documents\workspaces\repo may. > > > > > > > > > >> > > > > >> However, as soon as the remote updates with any changes on a given > > > > >> fetch/pull, the repo is put in a bad state permanently. > > > > >> > > > > >> I've pasted the output from gitk below... > > > > >> > > > > >> couldn't execute "git": file name too long > > > > >> couldn't execute "git": file name too long > > > > >> while executing > > > > >> "open $cmd r" > > > > >> (procedure "getallcommits" line 48) > > > > >> invoked from within > > > > >> "getallcommits" > > > > >> (procedure "readcache" line 80) > > > > >> invoked from within > > > > >> "readcache file827e200" > > > > >> ("eval" body line 1) > > > > >> invoked from within > > > > >> "eval $script" > > > > >> (procedure "dorunq" line 11) > > > > >> invoked from within > > > > >> "dorunq" > > > > >> ("after" script) > > > > >> > > > > >> Happy to gather whatever data needed. > > > > >> Thanks! > > > > >> - Bret Barkelew > > > > > >
next prev parent reply other threads:[~2019-01-10 18:55 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-04 2:21 Bret Barkelew [not found] ` <CAGyf7-HcncFOfmm5McEkOvCTkHNdePDSEQDZwEAK=z1bmC=QKw@mail.gmail.com> 2019-01-04 3:38 ` Bret Barkelew 2019-01-09 18:39 ` Johannes Schindelin 2019-01-09 18:48 ` Bret Barkelew 2019-01-10 15:19 ` Johannes Schindelin 2019-01-10 18:55 ` Bret Barkelew [this message] 2019-04-18 18:16 ` Bret Barkelew 2019-04-27 23:20 ` Johannes Schindelin 2019-05-29 16:40 ` Bret Barkelew 2019-05-29 18:07 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGTkKagTCw-EcMo3M1P3XVtjbTcm4HPjCWGZ1sM_NnJwH7v_hg@mail.gmail.com \ --to=bret@corthon.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=bturner@atlassian.com \ --cc=git@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git