git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Maurice McCabe <mmcc007@gmail.com>
To: git@vger.kernel.org
Cc: jonathantanmy@google.com
Subject: git issue with builds on Travis-CI
Date: Fri, 12 Oct 2018 22:21:57 -0700	[thread overview]
Message-ID: <CAGTUGAszwA63eYi2on_Pn4mSu4n2YDjv9kiakmbCT38gj30iNw@mail.gmail.com> (raw)

There is a problem on travis-ci with doing builds on Pull Requests
with multiple jobs. For each job it will build off the FETCH_HEAD. The
problem is that if the FETCH_HEAD changes while the build is running
(due to a commit), the subsequent jobs will build off the new
FETCH_HEAD. This results in loss of integrity of the build.

The fix would have been doing a fetch by the SHA-1 (commit) instead of
the FETCH_HEAD. But this results in an error:
"error: Server does not allow request for unadvertised object"

Since this is not working, the current option available to the people
at travis-ci is to abandon the build with an error message. This is
not a good user experience. The preferred option is to trigger a new
build when a commit is made.

You can see more details about the problem in this comment:
https://github.com/travis-ci/travis-ci/issues/8577#issuecomment-336596843
and the current discussion:
https://github.com/travis-ci/travis-ci/issues/10210

BTW: on reading the git mailing list a suggestion seems to be to ask
the server operator (GitHub in this case) to set:
"git config uploadpack.allowReachableSHA1InWant 1"
Apparently this has some security implications.

Does anyone have a suggestion how to do a fetch by SHA-1? Or is there
another approach to solve this issue on travis-ci?

Thnx,

Maurice

                 reply	other threads:[~2018-10-13  5:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGTUGAszwA63eYi2on_Pn4mSu4n2YDjv9kiakmbCT38gj30iNw@mail.gmail.com \
    --to=mmcc007@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).