git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Chris Webster <chris@webstech.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	"Chris. Webster via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] ci: github action - add check for whitespace errors
Date: Fri, 9 Oct 2020 22:26:35 -0700	[thread overview]
Message-ID: <CAGT1KpV+vcD59W2qWBsgg2qfSSLaJ37aVi__y5u=wHjsSDiiOQ@mail.gmail.com> (raw)
In-Reply-To: <xmqq8scfteh7.fsf@gitster.c.googlers.com>

On Fri, Oct 9, 2020 at 11:57 AM Junio C Hamano <gitster@pobox.com> wrote:

> Thanks.
>
> Another thing the resending does is that it can credit who helped
> the patch into the final shape with Reviewed-by/Helped-by etc.  If
> the maintainer must hunt for the names of those who had input to the
> discussion and judge the degree of contribution for a topic whose
> review has been delegated to trusted others, that defeats the whole
> point of delegation (I think the attached clarification may help).
>
> For this particular patch, I added Reviewed-by: naming you before
> applying.
>
> Thanks.
>

Thank you for moving forward with this.  I apologize for not
re-reviewing the SubmittingPatches doc.  I should have done that.

Thanks to Johannes for the input on this before it was submitted.
Will work on improving the commit messages with more credits.

Is there an opportunity here for a gitgitgadget command to send the
'consensus reached' email?  The value may be in deciding who is
getting the email and trying to select content from the PR comments.

...chris.

  reply	other threads:[~2020-10-10  5:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  7:28 [PATCH] ci: github action - add check for whitespace errors Chris. Webster via GitGitGadget
2020-09-22 17:07 ` Jeff King
2020-09-22 17:55   ` Junio C Hamano
2020-09-22 22:41     ` Chris Webster
2020-10-09  5:00       ` Chris Webster
2020-10-09 13:20         ` Johannes Schindelin
2020-10-09 16:23           ` Junio C Hamano
2020-10-09 17:59             ` Jeff King
2020-10-09 18:13               ` Junio C Hamano
2020-10-09 18:18                 ` Jeff King
2020-10-09 18:56                   ` Junio C Hamano
2020-10-10  5:26                     ` Chris Webster [this message]
2020-10-10  6:29                       ` Junio C Hamano
2020-09-22 22:17   ` Chris Webster
2020-09-24  6:51     ` Jeff King
2020-09-25  5:10       ` Chris Webster
2020-09-25  6:44         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGT1KpV+vcD59W2qWBsgg2qfSSLaJ37aVi__y5u=wHjsSDiiOQ@mail.gmail.com' \
    --to=chris@webstech.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).