From: Chris Webster <chris@webstech.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
"Chris. Webster via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] ci: github action - add check for whitespace errors
Date: Tue, 22 Sep 2020 15:41:57 -0700 [thread overview]
Message-ID: <CAGT1KpU4Kjv2PEAA7-bNbGp2DFvfsKqABuUK68128xkLjdcEhA@mail.gmail.com> (raw)
In-Reply-To: <xmqq1ritlmrk.fsf@gitster.c.googlers.com>
On Tue, Sep 22, 2020 at 10:55 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Jeff King <peff@peff.net> writes:
>
> > - this will run only on PRs. That's helpful for people using
> > GitGitGadget, but it might also be useful for people just running the
> > CI by pushing branches, or looking at CI builds of Junio's next or
> > seen branches. Could we make it work there? Obviously we wouldn't be
> > able to rely on having PR data, but I wonder if "git log
> > HEAD..$branch" would be sufficient.
>
> Yes, I like that very much. If a push triggers a CI run to notice
> whitespace breakage and other mechanically detectable errors, that
> would prevent embarrassment before even a pull request is opened.
This was originally started as a push action which was expected to be
in the GitGitGadget workflow. It was changed to run on PRs using the
more helpful PR data. The original GitGitGadget issue suggested a
build target to run the check, which could have been part of the CI
build (or a local build). Doing the check later as part of the PR
process is consistent with GitGitGadget performing linting on the PR
request, with similar opportunities for embarrassment.
...chris.
next prev parent reply other threads:[~2020-09-22 22:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 7:28 [PATCH] ci: github action - add check for whitespace errors Chris. Webster via GitGitGadget
2020-09-22 17:07 ` Jeff King
2020-09-22 17:55 ` Junio C Hamano
2020-09-22 22:41 ` Chris Webster [this message]
2020-10-09 5:00 ` Chris Webster
2020-10-09 13:20 ` Johannes Schindelin
2020-10-09 16:23 ` Junio C Hamano
2020-10-09 17:59 ` Jeff King
2020-10-09 18:13 ` Junio C Hamano
2020-10-09 18:18 ` Jeff King
2020-10-09 18:56 ` Junio C Hamano
2020-10-10 5:26 ` Chris Webster
2020-10-10 6:29 ` Junio C Hamano
2020-09-22 22:17 ` Chris Webster
2020-09-24 6:51 ` Jeff King
2020-09-25 5:10 ` Chris Webster
2020-09-25 6:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGT1KpU4Kjv2PEAA7-bNbGp2DFvfsKqABuUK68128xkLjdcEhA@mail.gmail.com \
--to=chris@webstech.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).