git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Alexander Ost <ost@ieee.org>
To: git@vger.kernel.org
Subject: [BUG] `make install' partly ignores `NO_INSTALL_HARDLINKS'
Date: Wed, 12 Aug 2020 10:15:55 +0200	[thread overview]
Message-ID: <CAGNCYk3hGWHuSb4vDzrBE54P5y6Sm+TwfVrCfHD0LnLQWSr9nA@mail.gmail.com> (raw)

Hello,

I tried to install git on a filesystem that does not support hard
links (specifically, on a Linux bind mount).

Despite installing with `make NO_INSTALL_HARDLINKS=1 install', the
installation process tries to create hard links, and the installation
fails (a quick workaround is `sed -i git-gui/Makefile -e "s/ln /ln -s
/g"').

Here's the bugreport:

vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.

What did you do before the bug happened? (Steps to reproduce your issue)
./configure --prefix=/filesystem_without_hardlink_support
make
make NO_INSTALL_HARDLINKS=1 install

What did you expect to happen? (Expected behavior)
Successful installation.

What happened instead? (Actual behavior)
Installation fails with error
  ln: failed to create hard link
‘/filesystem_without_hardlink_support/libexec/git-core/git-citool’ =>
‘/filesystem_without_hardlink_support/libexec/git-core/git-gui’:
Operation not permitted

What's different between what you expected and what actually happened?
The makefile `git-gui/Makefile' tries to create hard links. This is
not expected when running `make NO_INSTALL_HARDLINKS=1 install'

Anything else you want to add:

Please review the rest of the bug report below.
You can delete any lines you don't wish to share.

[System Info]
git version:
git version 2.27.0
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
uname: Linux 3.10.0-957.10.1.el7.x86_64 #1 SMP Mon Mar 18 15:06:45 UTC
2019 x86_64
compiler info: gnuc: 4.8
libc info: glibc: 2.17


[Enabled Hooks]
not run from a git repository - no hooks to show
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thanks for checking this!

Best,
/alex

             reply	other threads:[~2020-08-12  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12  8:15 Alexander Ost [this message]
2020-08-13 21:45 ` Eric Sunshine
2020-08-13 21:52   ` Junio C Hamano
2020-08-14  8:33     ` Alexander Ost
2020-08-14 15:02     ` Đoàn Trần Công Danh
2020-08-14 17:26       ` Junio C Hamano
2020-08-15  1:15         ` Đoàn Trần Công Danh
2020-08-17 16:40           ` Junio C Hamano
2020-08-17 17:06             ` Đoàn Trần Công Danh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGNCYk3hGWHuSb4vDzrBE54P5y6Sm+TwfVrCfHD0LnLQWSr9nA@mail.gmail.com \
    --to=ost@ieee.org \
    --cc=git@vger.kernel.org \
    --subject='Re: [BUG] `make install'\'' partly ignores `NO_INSTALL_HARDLINKS'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).