From: Orgad Shaneh <orgads@gmail.com>
To: git <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] t5403: Refactor
Date: Mon, 24 Dec 2018 22:54:23 +0200 [thread overview]
Message-ID: <CAGHpTBLP2emg5L9vT9OPneapNP_6eHRXYF-9jT20ZkD07HJKJw@mail.gmail.com> (raw)
In-Reply-To: <CAGHpTB+9L55Gvezhb7x6Kb49WS_nfzmKdVvpH3_=6GM7y8YQ_g@mail.gmail.com>
Hi Johannes,
Thanks for reviewing this.
On Fri, Dec 21, 2018 at 6:06 PM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>
> Hi Orgad,
>
> On Thu, 20 Dec 2018, orgads@gmail.com wrote:
>
> > diff --git a/t/t5403-post-checkout-hook.sh b/t/t5403-post-checkout-hook.sh
> > index fc898c9eac..7e941537f9 100755
> > --- a/t/t5403-post-checkout-hook.sh
> > +++ b/t/t5403-post-checkout-hook.sh
> > @@ -7,67 +7,48 @@ test_description='Test the post-checkout hook.'
> > . ./test-lib.sh
> >
> > test_expect_success setup '
> > - echo Data for commit0. >a &&
> > - echo Data for commit0. >b &&
> > - git update-index --add a &&
> > - git update-index --add b &&
> > - tree0=$(git write-tree) &&
> > - commit0=$(echo setup | git commit-tree $tree0) &&
> > - git update-ref refs/heads/master $commit0 &&
> > - git clone ./. clone1 &&
> > - git clone ./. clone2 &&
> > - GIT_DIR=clone2/.git git branch new2 &&
> > - echo Data for commit1. >clone2/b &&
> > - GIT_DIR=clone2/.git git add clone2/b &&
> > - GIT_DIR=clone2/.git git commit -m new2
> > + test_commit one &&
> > + test_commit two &&
> > + test_commit three three &&
>
> A very nice simplification (but please use tabs to indent).
Thanks. I already did. I sent these patches twice - first revision had
spaces, and the second one had tabs.
> > + mv .git/hooks-disabled .git/hooks
> > '
> >
> > -for clone in 1 2; do
> > - cat >clone${clone}/.git/hooks/post-checkout <<'EOF'
> > +cat >.git/hooks/post-checkout <<'EOF'
> > #!/bin/sh
> > -echo $@ > $GIT_DIR/post-checkout.args
> > +echo $@ > .git/post-checkout.args
>
> While at it, you could lose the space after the redirector that we seem to
> no longer prefer:
>
> > +echo $@ >.git/post-checkout.args
>
> And since we are already cleaning up, we could easily move use
> write_script instead, *and* move it into the `setup` test case (which
> makes it easier to use something like
>
> sh t5403-post-checkout-hook.sh --run=1,13
Done.
> The rest looks good (modulo indentation issues). I would have preferred
> the separate concerns to be addressed in individual commits (one commit to
> replace the `awk` calls, one to avoid the clones, one to simplify by using
> `test_commit`, etc), as that would have been easier to review. But others
> might disagree (Junio recently made the case of smooshing separate
> concerns into single commits, even squashing two of my patches into one
> against my wish), so... I guess you don't have to change this.
I also like commit granularity, but since I'm not familiar with the
workflow in the mailing list, how to amend and resend commits etc. I
try to keep the number of commits low :)
Thanks,
- Orgad
next prev parent reply other threads:[~2018-12-24 20:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 21:48 [PATCH 1/2] t5403: Refactor orgads
2018-12-20 21:48 ` [PATCH 2/2] Rebase: Run post-checkout hook on checkout orgads
2018-12-21 16:12 ` Johannes Schindelin
2018-12-24 21:24 ` Orgad Shaneh
2018-12-21 16:06 ` [PATCH 1/2] t5403: Refactor Johannes Schindelin
[not found] ` <CAGHpTB+9L55Gvezhb7x6Kb49WS_nfzmKdVvpH3_=6GM7y8YQ_g@mail.gmail.com>
2018-12-24 20:54 ` Orgad Shaneh [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-20 21:55 orgads
2018-12-24 21:24 [PATCH] Rebase: Run post-checkout hook on checkout orgads
2018-12-24 21:24 ` [PATCH 1/2] t5403: Refactor orgads
2018-12-28 22:34 ` Junio C Hamano
2018-12-29 3:06 ` Ramsay Jones
2018-12-29 21:36 ` Orgad Shaneh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGHpTBLP2emg5L9vT9OPneapNP_6eHRXYF-9jT20ZkD07HJKJw@mail.gmail.com \
--to=orgads@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).