From: Orgad Shaneh <orgads@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH] doc: fix capitalization in porcelain v2 section
Date: Tue, 28 Sep 2021 23:42:23 +0300 [thread overview]
Message-ID: <CAGHpTBKkET3dcsjq0oQshMmxDRoA6rMOhUoPsAaG634_sHizRg@mail.gmail.com> (raw)
In-Reply-To: <xmqqsfxppylh.fsf@gitster.g>
On Mon, Sep 27, 2021 at 11:12 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > Subject: Re: [PATCH] doc: fix capitalization in porcelain v2 section
> > From: Orgad Shaneh <orgads@gmail.com>
>
> Between "doc" and "porcelain v2 section", there is this level called
> "page" ;-) When this commit is mixed together with other commits in
> "git shortlog" output, it will be hard to tell that this is about
> fixing documentation for which command, so you must give it to your
> readers.
>
> Subject: doc: match XY placeholder in status --porcelain-v2 output
>
> or something like that, perhaps?
>
> Thanks.
>
> >
> > The summary line had xy, while the description (and other sub-sections)
> > has XY.
> >
> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> > ---
> > doc: fix capitalization in porcelain v2 section
> >
> > The summary line had xy, while the description (and other sub-sections)
> > has XY.
> >
> > Signed-off-by: Orgad Shaneh orgads@gmail.com
> >
> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1095%2Forgads%2Fstatus-doc-v1
> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1095/orgads/status-doc-v1
> > Pull-Request: https://github.com/git/git/pull/1095
> >
> > Documentation/git-status.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/git-status.txt b/Documentation/git-status.txt
> > index 83f38e31981..c33a3d8d532 100644
> > --- a/Documentation/git-status.txt
> > +++ b/Documentation/git-status.txt
> > @@ -363,7 +363,7 @@ Field Meaning
> > Unmerged entries have the following format; the first character is
> > a "u" to distinguish from ordinary changed entries.
> >
> > - u <xy> <sub> <m1> <m2> <m3> <mW> <h1> <h2> <h3> <path>
> > + u <XY> <sub> <m1> <m2> <m3> <mW> <h1> <h2> <h3> <path>
> >
> > ....
> > Field Meaning
> >
> > base-commit: ddb1055343948e0d0bc81f8d20245f1ada6430a0
Fine with me. Should I resubmit the patch, or will you push it with
the revised subject?
- Orgad
next prev parent reply other threads:[~2021-09-28 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 3:48 [PATCH] doc: fix capitalization in porcelain v2 section Orgad Shaneh via GitGitGadget
2021-09-27 20:09 ` Junio C Hamano
2021-09-27 20:12 ` Junio C Hamano
2021-09-28 20:42 ` Orgad Shaneh [this message]
2021-09-28 23:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGHpTBKkET3dcsjq0oQshMmxDRoA6rMOhUoPsAaG634_sHizRg@mail.gmail.com \
--to=orgads@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).