From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.80.0/22 X-Spam-Status: No, score=-11.4 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 32D3A1F44D for ; Tue, 9 Apr 2024 17:31:23 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=OOtQwR25; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 941A11F24E97 for ; Tue, 9 Apr 2024 17:31:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2EDAA156897; Tue, 9 Apr 2024 17:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OOtQwR25" Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E6D156248 for ; Tue, 9 Apr 2024 17:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712683867; cv=none; b=nmj6UsbGaZ7G+LuFf6vSn0PX6SVhMTuYoOUY8R/6PHgM6fFfdAXnHAD/R9JUPZTXv6RacDb013TP/LEndb7OE2HJgMQCtlr1b4wC8TVRrIiH/mHYl/AGFEiD3SIWP9i42uu+feRAiRHStUrR3kzMrNxnMdV+nKNTmrHukACu19Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712683867; c=relaxed/simple; bh=OFowAFFXw34SjGI7EvwswvJaTjG0+159AzLFntMj/uI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=alY/e822otss2zdC+wJb1W2oIM4V8SNoaHtmhuyQfj6onG8ZewtN9OmkN0KAPhF49qkB4skSIJH+6WLM83AwYm4GCOQ6tk11LTfphyXVK1EMFD7xPqFwCZ2lw1106xCSMT7zhG1ojjtTS4drINJdG3eiSxzSBv8KZM+EJkOBrSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OOtQwR25; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4348110e888so17431cf.1 for ; Tue, 09 Apr 2024 10:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712683865; x=1713288665; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OFowAFFXw34SjGI7EvwswvJaTjG0+159AzLFntMj/uI=; b=OOtQwR25hyq6azoNs84GlHZuDWk1cqqh8vcvP0fCaHWAfrmrAMP8wjfl9EPIG5BtCs 7yZAPKbEOy/29lpIm84cHnuzAZAMoxkNpRECeAl42tDISO1351rdAIKrYqzFfKnqWdz/ 9GrZIOC2Oo5GI/lYvgfUpxYWlc5kZ5yVuP6q/w4YTHQO3Fldnn2qsIRgazONAHD6kKOI t7MoNkWBZum3wamc46ZU+C7ygKyuT3uRkCekXD+JrQIFuaaz5BWp6Tb0Tgkjr0fsQX5E 6UwEEoQjzzIkgN7AFsXd9VharJYSmdR5cTBKYdG2D0j7N+X+i/F0/gYTBsf1541vk5Cm 7Rmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712683865; x=1713288665; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OFowAFFXw34SjGI7EvwswvJaTjG0+159AzLFntMj/uI=; b=BCpi+KsxPy2lJf28y5RqXm3Bs1Zsg8Q8xR5Kp1mmdQyquSHWmwj3b0GUufHW0/8Sjf 64Es9O87MTLmxNeE+9Ndjq3xR4/HYoH6v8QqIvqZG/wE3MQSl2shXEatvQ48wRqFsE7t 9YB86pxGPIITqTfrnXSc7dwguhLV71JSJiz4Ldsq9xhQivF4NJwAn+jg3GOEsxmPJdsa hgQY4KJMM0T2P0enddydDYe8oRy9zu6NgEDPxiDIKCx2gxf4FRsEBue1ReOq4+0h4ag4 y7NSL5NCBHnLgIbdmyFjCuEQPw5VLmpJVYm0TLtM7Ws25YR1/PTW/3G08MpapMARC0Mc qriA== X-Forwarded-Encrypted: i=1; AJvYcCWajjOiNvVfX3INRej5T49KRJnJRxcCCAMs/djAJjSZwuUbKByww8q2Lsnx8rzaKp/dKJTefUbJAKCFQ3f1iVf2WEKD X-Gm-Message-State: AOJu0YzZXCBW3O+bkWvFVe4g+TLDjbBYQUQmzfA99RpzbFF8LpPsLe+D 3imRPd8InmnRGgmI+lnip3M1MJNiMFUnijBFPU1mTgovXBWPNtSffZ1dXTj5UPur1iquFhb5DjP sbV5+XNtNEF/c7cFHsli5Rg/IY9moDOkCq2zb X-Google-Smtp-Source: AGHT+IEZPpgbPRcs+dS1Oh7G9/TAYUWL0PX5JKTNXMP0DTHRDPSi6vaC4K5+yxhTsy90+wDxchmyMLHG2CmtVOX4Pfw= X-Received: by 2002:a05:622a:4888:b0:430:ed37:bad0 with SMTP id fc8-20020a05622a488800b00430ed37bad0mr322865qtb.13.1712683865123; Tue, 09 Apr 2024 10:31:05 -0700 (PDT) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <037001da8935$4a6e3720$df4aa560$@nexbridge.com> <5663500c-ea40-45a6-bb7d-c906aee4350c@gmail.com> In-Reply-To: <5663500c-ea40-45a6-bb7d-c906aee4350c@gmail.com> From: Calvin Wan Date: Tue, 9 Apr 2024 10:30:54 -0700 Message-ID: Subject: Re: [RFD] Libification proposal: separate internal and external interfaces To: phillip.wood@dunelm.org.uk Cc: Junio C Hamano , "brian m. carlson" , rsbecker@nexbridge.com, Git Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 9, 2024 at 2:40=E2=80=AFAM Phillip Wood wrote: > > Indeed, the last set of patches allow git to be built with the same > library that external programs can use which I thought was very welcome. > This proposal seems to be backing away from that. One of the questions I was grappling with was, do we want to expose all functions to external users? While it is debatable whether we would like that exposure for some of the files in libstdgit, functions in wrapper.c and usage.c seem like clear candidates for functions that have no value being exposed externally while also making it more difficult to maintain such a library in the future.